Add tests for changed logic, fix as_bytes DKIM signing bug

New tests:
- BaseFile.get_data() with str, bytes, IO, and None
- SMTPResponse: defaults, set_status, success, refused_recipients
- Message.as_bytes() with DKIM signing

The as_bytes test uncovered a bug: as_bytes() called sign_string()
(expects str) instead of sign_bytes() (expects bytes), causing
TypeError when DKIM signing was enabled. Fixed.

Author: lavr

emails/message.py

@@ -356,7 +356,7 @@ def as_bytes(self, message_cls: type | None = None) -> bytes:
         """
         r = self.build_message(message_cls=message_cls).as_bytes()
         if self._signer:
-            r = self.sign_string(r)
+            r = self.sign_bytes(r)
         return r
 
 

emails/testsuite/message/test_dkim.py

@@ -132,6 +132,16 @@ def test_dkim_error():
     m.as_message()
 
 
+def test_dkim_as_bytes():
+
+    priv_key, pub_key = _generate_key(length=1024)
+    message = Message(**common_email_data())
+    message.dkim(key=priv_key, selector='_dkim', domain='somewhere.net')
+    result = message.as_bytes()
+    assert isinstance(result, bytes)
+    assert b'DKIM-Signature: ' in result
+
+
 def test_dkim_sign_twice():
 
     # Test #44:

emails/testsuite/smtp/test_smtp_response.py

@@ -0,0 +1,45 @@
+# encoding: utf-8
+from emails.backend.response import SMTPResponse
+
+
+def test_smtp_response_defaults():
+    r = SMTPResponse()
+    assert r.status_code is None
+    assert r.status_text is None
+    assert r.refused_recipients == {}
+    assert r.esmtp_opts is None
+    assert r.rcpt_options is None
+    assert not r.success
+    assert r.error is None
+
+
+def test_smtp_response_set_status():
+    r = SMTPResponse()
+    r.set_status('mail', 250, 'OK')
+    assert r.status_code == 250
+    assert r.status_text == 'OK'
+    assert r.last_command == 'mail'
+    assert len(r.responses) == 1
+
+
+def test_smtp_response_success():
+    r = SMTPResponse()
+    r.set_status('data', 250, 'OK')
+    assert not r.success  # _finished is False
+    r._finished = True
+    assert r.success
+
+
+def test_smtp_response_refused_recipients():
+    r = SMTPResponse()
+    r.refused_recipients = {}
+    r.refused_recipients['bad@example.com'] = (550, b'User unknown')
+    assert 'bad@example.com' in r.refused_recipients
+    assert r.refused_recipients['bad@example.com'] == (550, b'User unknown')
+
+
+def test_smtp_response_exception():
+    exc = Exception('connection failed')
+    r = SMTPResponse(exception=exc)
+    assert r.error is exc
+    assert not r.success

emails/testsuite/store/test_store.py

@@ -1,8 +1,10 @@
 # encoding: utf-8
+from io import BytesIO
+
 import pytest
 import emails
 import emails.store
-from emails.store.file import fix_content_type
+from emails.store.file import BaseFile, fix_content_type
 
 
 def test_fix_content_type():
@@ -47,6 +49,26 @@ def test_store_unique_name():
     assert f2.content_id != f3.content_id
 
 
+def test_get_data_str():
+    f = BaseFile(data='hello')
+    assert f.data == 'hello'
+
+
+def test_get_data_bytes():
+    f = BaseFile(data=b'hello')
+    assert f.data == b'hello'
+
+
+def test_get_data_filelike():
+    f = BaseFile(data=BytesIO(b'hello'))
+    assert f.data == b'hello'
+
+
+def test_get_data_none():
+    f = BaseFile()
+    assert f.data is None
+
+
 def test_store_commons2():
     store = emails.store.MemoryFileStore()
     f1 = store.add({'uri': '/a/c.gif'})