chore(saved-projects): drop redundant rank field; use JSON array order

The `rank: u32` field on each saved project was a sort key that just
reproduced the order of the JSON array — and the file is hand-edited
(no in-app writer yet), so reordering meant renumbering all the ranks.
Removing the field makes reordering a cut-and-paste of the `{ ... }`
block, and eliminates a class of accidental-tie / off-by-one mistakes
that's easy to introduce when inserting an entry into a numbered list.

Behavior change is one line: `load_projects_from` no longer calls
`sort_by_key(|p| p.rank)`. The picker UI (`projects_picker_menu_items`
in `workspace/view.rs`) already iterated the loaded vec in order with
no re-sorting, so removing the sort makes the vec's deserialization
order — i.e. JSON array order — the displayed order.

Backward compat is free: `serde_json` silently ignores unknown fields
by default, so existing `~/.warp-oss/projects.json` files with `rank`
keys continue to parse cleanly — the keys are just dropped on read.
No migration needed.

Renamed the `sorts_by_rank_ascending` test to `preserves_file_order`
with a flipped expectation that documents the new invariant.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: lawsmd

app/src/saved_projects/mod.rs

@@ -21,7 +21,6 @@ pub struct Project {
     pub name: String,
     pub cwd: PathBuf,
     pub color: String,
-    pub rank: u32,
 }
 
 #[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)]
@@ -31,10 +30,10 @@ pub struct ProjectsConfig {
 }
 
 /// Reads `~/.warp-oss/projects.json` (or whatever `warp_home_projects_file_path()` resolves
-/// to for the current channel), expands `~` in each `cwd`, and returns the list sorted by
-/// `rank` ascending. Missing file or empty `projects` array → empty vec (debug-logged, not
-/// an error). Malformed JSON → empty vec with an error log so the picker never crashes the
-/// app over a typo.
+/// to for the current channel), expands `~` in each `cwd`, and returns the list in the
+/// order entries appear in the JSON `projects` array (top-of-file first). Missing file or
+/// empty `projects` array → empty vec (debug-logged, not an error). Malformed JSON → empty
+/// vec with an error log so the picker never crashes the app over a typo.
 pub fn load_projects() -> Vec<Project> {
     let Some(path) = warp_core::paths::warp_home_projects_file_path() else {
         return vec![];
@@ -67,7 +66,6 @@ fn load_projects_from(path: &Path) -> Vec<Project> {
             project.cwd = expanded;
         }
     }
-    projects.sort_by_key(|p| p.rank);
     projects
 }
 

app/src/saved_projects/saved_projects_test.rs

@@ -31,21 +31,21 @@ fn empty_projects_array_returns_empty() {
 }
 
 #[test]
-fn sorts_by_rank_ascending() {
+fn preserves_file_order() {
     let dir = tempfile::tempdir().unwrap();
     let path = write_json(
         &dir,
         r##"{
             "projects": [
-                { "name": "Beta",  "cwd": "/b", "color": "#aaaaaa", "rank": 3 },
-                { "name": "Alpha", "cwd": "/a", "color": "#bbbbbb", "rank": 1 },
-                { "name": "Gamma", "cwd": "/g", "color": "#cccccc", "rank": 2 }
+                { "name": "Beta",  "cwd": "/b", "color": "#aaaaaa" },
+                { "name": "Alpha", "cwd": "/a", "color": "#bbbbbb" },
+                { "name": "Gamma", "cwd": "/g", "color": "#cccccc" }
             ]
         }"##,
     );
     let projects = load_projects_from(&path);
     let names: Vec<&str> = projects.iter().map(|p| p.name.as_str()).collect();
-    assert_eq!(names, vec!["Alpha", "Gamma", "Beta"]);
+    assert_eq!(names, vec!["Beta", "Alpha", "Gamma"]);
 }
 
 #[test]
@@ -55,7 +55,6 @@ fn round_trip_serde() {
             name: "Acme".into(),
             cwd: PathBuf::from("C:\\projects\\acme-services"),
             color: "#2bd7fb".into(),
-            rank: 2,
         }],
     };
     let serialized = serde_json::to_string(&original).unwrap();
@@ -68,7 +67,6 @@ fn project(name: &str, cwd: &str) -> Project {
         name: name.into(),
         cwd: PathBuf::from(cwd),
         color: "#ff00ff".into(),
-        rank: 0,
     }
 }
 
@@ -124,7 +122,7 @@ fn tilde_expanded_at_load() {
     let dir = tempfile::tempdir().unwrap();
     let path = write_json(
         &dir,
-        r##"{"projects": [{ "name": "Cfg", "cwd": "~/foo/bar", "color": "#999999", "rank": 1 }]}"##,
+        r##"{"projects": [{ "name": "Cfg", "cwd": "~/foo/bar", "color": "#999999" }]}"##,
     );
     let projects = load_projects_from(&path);
     let cwd = &projects[0].cwd;