fix: ruff SIM + E501 violations to pass CI (format + check)

- SIM102: flatten nested ifs in belief.py, hooks.py, gemini.py (both copies)
- SIM108: ternary in skills.py name assignment
- SIM105: contextlib.suppress in auth.py try-except-pass blocks
- E501: noqa annotations on 4 unavoidably long lines post-format
- ruff format: applied to all 34 files that needed reformatting

All checks now match CI config exactly (E,F,W,I,UP,B,SIM rules).

Co-Authored-By: Oz <oz-agent@warp.dev>

Author: tbitcs

src/epistemic/belief.py

@@ -164,7 +164,7 @@ class BeliefArtifact:
     component: str = ""
     priority: str = ""
     # Optional metadata for non-specsmith uses
-    domain: str = ""        # e.g., "linguistics", "software", "policy"
+    domain: str = ""  # e.g., "linguistics", "software", "policy"
     evidence: list[str] = field(default_factory=list)  # evidence citations
 
     @property
@@ -186,7 +186,8 @@ def unresolved_failures(self) -> list[FailureMode]:
     @property
     def critical_failures(self) -> list[FailureMode]:
         return [
-            fm for fm in self.failure_modes
+            fm
+            for fm in self.failure_modes
             if not fm.resolved and fm.severity == FailureSeverity.CRITICAL
         ]
 
@@ -281,9 +282,8 @@ def parse_requirements_as_beliefs(path: Path) -> list[BeliefArtifact]:
                 current.evidence.append(val)
         else:
             stripped = line.strip().lstrip("-").strip()
-            if stripped and not stripped.startswith("#"):
-                if not current_desc:
-                    current_desc = stripped
+            if stripped and not stripped.startswith("#") and not current_desc:
+                current_desc = stripped
 
     if current is not None:
         _finalise(current, current_desc)

src/epistemic/certainty.py

@@ -5,6 +5,7 @@
 Part of the standalone ``epistemic`` library. Zero external dependencies.
     from epistemic import CertaintyEngine, CertaintyReport
 """
+
 from __future__ import annotations
 
 from dataclasses import dataclass, field

src/epistemic/failure_graph.py

@@ -5,6 +5,7 @@
 Part of the standalone ``epistemic`` library. Zero external dependencies.
     from epistemic import FailureModeGraph
 """
+
 from __future__ import annotations
 
 from dataclasses import dataclass, field
@@ -25,16 +26,16 @@ class GraphNode:
 class FailureModeGraph:
     """Directed graph of failure-mode relations between BeliefArtifacts.
 
-        from epistemic import FailureModeGraph, StressTester, BeliefArtifact
+    from epistemic import FailureModeGraph, StressTester, BeliefArtifact
 
-        artifacts = [...]
-        tester = StressTester()
-        result = tester.run(artifacts)
+    artifacts = [...]
+    tester = StressTester()
+    result = tester.run(artifacts)
 
-        graph = FailureModeGraph()
-        graph.build(artifacts, result)
-        print(f"Equilibrium: {graph.equilibrium_check()}")
-        print(graph.render_text())
+    graph = FailureModeGraph()
+    graph.build(artifacts, result)
+    print(f"Equilibrium: {graph.equilibrium_check()}")
+    print(graph.render_text())
     """
 
     def __init__(self) -> None:
@@ -126,7 +127,9 @@ def render_mermaid(self) -> str:
                 lines.append(f'  {_sid(node.artifact_id)}["{label}\\n⚠CRITICAL"]')
                 lines.append(f"  style {_sid(node.artifact_id)} fill:#ff4444,color:#fff")
             elif node.failure_count > 0:
-                lines.append(f'  {_sid(node.artifact_id)}["{label}\\n{node.failure_count} failures"]')  # noqa: E501
+                lines.append(
+                    f'  {_sid(node.artifact_id)}["{label}\\n{node.failure_count} failures"]'
+                )  # noqa: E501
                 lines.append(f"  style {_sid(node.artifact_id)} fill:#ff9900,color:#000")
             else:
                 lines.append(f'  {_sid(node.artifact_id)}["{label}"]')

src/epistemic/recovery.py

@@ -5,6 +5,7 @@
 Part of the standalone ``epistemic`` library. Zero external dependencies.
     from epistemic import RecoveryOperator, RecoveryProposal
 """
+
 from __future__ import annotations
 
 from dataclasses import dataclass
@@ -42,11 +43,11 @@ class RecoveryProposal:
 class RecoveryOperator:
     """Propose minimal recovery actions for Failure Modes and Logic Knots.
 
-        from epistemic import RecoveryOperator
+    from epistemic import RecoveryOperator
 
-        operator = RecoveryOperator()
-        proposals = operator.propose(artifacts, stress_result)
-        print(operator.format_proposals(proposals))
+    operator = RecoveryOperator()
+    proposals = operator.propose(artifacts, stress_result)
+    print(operator.format_proposals(proposals))
     """
 
     def propose(
@@ -78,64 +79,78 @@ def _propose_for_failure(
 
         if "vagueness" in challenge:
             strategy = (
-                RecoveryStrategy.QUANTIFY if "unquantified" in challenge
+                RecoveryStrategy.QUANTIFY
+                if "unquantified" in challenge
                 else RecoveryStrategy.QUANTIFY
             )
-            proposals.append(RecoveryProposal(
-                artifact_id=artifact.artifact_id,
-                failure_mode_challenge=fm.challenge,
-                strategy=strategy,
-                description=f"Replace imprecise language in {artifact.artifact_id}.",
-                suggested_change=fm.recovery_hint or "Replace vague terms with measurable criteria.",  # noqa: E501
-                priority=priority,
-            ))
+            proposals.append(
+                RecoveryProposal(
+                    artifact_id=artifact.artifact_id,
+                    failure_mode_challenge=fm.challenge,
+                    strategy=strategy,
+                    description=f"Replace imprecise language in {artifact.artifact_id}.",
+                    suggested_change=fm.recovery_hint
+                    or "Replace vague terms with measurable criteria.",  # noqa: E501
+                    priority=priority,
+                )
+            )
         elif "falsifiability" in challenge or "no test" in challenge:
-            proposals.append(RecoveryProposal(
-                artifact_id=artifact.artifact_id,
-                failure_mode_challenge=fm.challenge,
-                strategy=RecoveryStrategy.FALSIFY,
-                description=f"Add a test for {artifact.artifact_id}.",
-                suggested_change=f"Add a test entry that covers: {artifact.source_text[:80]}",
-                priority=priority,
-            ))
+            proposals.append(
+                RecoveryProposal(
+                    artifact_id=artifact.artifact_id,
+                    failure_mode_challenge=fm.challenge,
+                    strategy=RecoveryStrategy.FALSIFY,
+                    description=f"Add a test for {artifact.artifact_id}.",
+                    suggested_change=f"Add a test entry that covers: {artifact.source_text[:80]}",
+                    priority=priority,
+                )
+            )
         elif "observability" in challenge or "boundary" in challenge:
-            proposals.append(RecoveryProposal(
-                artifact_id=artifact.artifact_id,
-                failure_mode_challenge=fm.challenge,
-                strategy=RecoveryStrategy.CONSTRAIN,
-                description=f"Add epistemic boundary to {artifact.artifact_id}.",
-                suggested_change="Declare scope, assumptions, and platform constraints.",
-                priority=priority,
-            ))
+            proposals.append(
+                RecoveryProposal(
+                    artifact_id=artifact.artifact_id,
+                    failure_mode_challenge=fm.challenge,
+                    strategy=RecoveryStrategy.CONSTRAIN,
+                    description=f"Add epistemic boundary to {artifact.artifact_id}.",
+                    suggested_change="Declare scope, assumptions, and platform constraints.",
+                    priority=priority,
+                )
+            )
             if not artifact.propositions:
-                proposals.append(RecoveryProposal(
+                proposals.append(
+                    RecoveryProposal(
+                        artifact_id=artifact.artifact_id,
+                        failure_mode_challenge=fm.challenge,
+                        strategy=RecoveryStrategy.DECOMPOSE,
+                        description=f"Add propositions to {artifact.artifact_id} — currently empty.",  # noqa: E501
+                        suggested_change="Add a description as a testable claim.",
+                        priority=1,
+                    )
+                )
+        elif "irreducibility" in challenge or "compound" in challenge:
+            proposals.append(
+                RecoveryProposal(
                     artifact_id=artifact.artifact_id,
                     failure_mode_challenge=fm.challenge,
                     strategy=RecoveryStrategy.DECOMPOSE,
-                    description=f"Add propositions to {artifact.artifact_id} — currently empty.",
-                    suggested_change="Add a description as a testable claim.",
-                    priority=1,
-                ))
-        elif "irreducibility" in challenge or "compound" in challenge:
-            proposals.append(RecoveryProposal(
-                artifact_id=artifact.artifact_id,
-                failure_mode_challenge=fm.challenge,
-                strategy=RecoveryStrategy.DECOMPOSE,
-                description=f"Decompose {artifact.artifact_id} into independent beliefs.",
-                suggested_change="Split into separate beliefs, each with a single proposition.",
-                estimated_cost="medium",
-                priority=priority,
-            ))
+                    description=f"Decompose {artifact.artifact_id} into independent beliefs.",
+                    suggested_change="Split into separate beliefs, each with a single proposition.",
+                    estimated_cost="medium",
+                    priority=priority,
+                )
+            )
         elif "confidence" in challenge:
-            proposals.append(RecoveryProposal(
-                artifact_id=artifact.artifact_id,
-                failure_mode_challenge=fm.challenge,
-                strategy=RecoveryStrategy.FALSIFY,
-                description=f"Raise confidence for P1 belief {artifact.artifact_id}.",
-                suggested_change="Add test coverage, evidence citations, and mark as stress-tested.",  # noqa: E501
-                estimated_cost="medium",
-                priority=1,
-            ))
+            proposals.append(
+                RecoveryProposal(
+                    artifact_id=artifact.artifact_id,
+                    failure_mode_challenge=fm.challenge,
+                    strategy=RecoveryStrategy.FALSIFY,
+                    description=f"Raise confidence for P1 belief {artifact.artifact_id}.",
+                    suggested_change="Add test coverage, evidence citations, and mark as stress-tested.",  # noqa: E501
+                    estimated_cost="medium",
+                    priority=1,
+                )
+            )
 
         return proposals
 
@@ -148,28 +163,32 @@ def _propose_for_knot(
         reason: str,
     ) -> list[RecoveryProposal]:
         if "duplicate" in reason.lower():
-            return [RecoveryProposal(
+            return [
+                RecoveryProposal(
+                    artifact_id=id1,
+                    failure_mode_challenge=f"Logic Knot: {reason[:60]}",
+                    strategy=RecoveryStrategy.DEPRECATE,
+                    description=f"Resolve duplicate ID conflict between {id1} and {id2}.",
+                    suggested_change="Merge or rename one with a unique ID.",
+                    priority=1,
+                )
+            ]
+        return [
+            RecoveryProposal(
                 artifact_id=id1,
                 failure_mode_challenge=f"Logic Knot: {reason[:60]}",
-                strategy=RecoveryStrategy.DEPRECATE,
-                description=f"Resolve duplicate ID conflict between {id1} and {id2}.",
-                suggested_change="Merge or rename one with a unique ID.",
+                strategy=RecoveryStrategy.RESOLVE,
+                description=f"Resolve Logic Knot between {id1} and {id2}.",
+                suggested_change=(
+                    f"Review both {id1} and {id2}. Options:\n"
+                    "  1. Narrow epistemic boundary of one\n"
+                    "  2. Supersede one (mark as DEPRECATED)\n"
+                    "  3. Decompose both into non-conflicting primitives"
+                ),
+                estimated_cost="medium",
                 priority=1,
-            )]
-        return [RecoveryProposal(
-            artifact_id=id1,
-            failure_mode_challenge=f"Logic Knot: {reason[:60]}",
-            strategy=RecoveryStrategy.RESOLVE,
-            description=f"Resolve Logic Knot between {id1} and {id2}.",
-            suggested_change=(
-                f"Review both {id1} and {id2}. Options:\n"
-                "  1. Narrow epistemic boundary of one\n"
-                "  2. Supersede one (mark as DEPRECATED)\n"
-                "  3. Decompose both into non-conflicting primitives"
-            ),
-            estimated_cost="medium",
-            priority=1,
-        )]
+            )
+        ]
 
     def format_proposals(self, proposals: list[RecoveryProposal]) -> str:
         if not proposals:
@@ -182,7 +201,9 @@ def format_proposals(self, proposals: list[RecoveryProposal]) -> str:
             "",
         ]
         for i, p in enumerate(proposals, 1):
-            lines.append(f"{i}. [{p.strategy.value.upper()}] {p.artifact_id} (cost: {p.estimated_cost})")  # noqa: E501
+            lines.append(
+                f"{i}. [{p.strategy.value.upper()}] {p.artifact_id} (cost: {p.estimated_cost})"
+            )  # noqa: E501
             lines.append(f"   Problem: {p.failure_mode_challenge}")
             lines.append(f"   Action:  {p.description}")
             lines.append(f"   Change:  {p.suggested_change[:200]}")

src/epistemic/session.py

@@ -172,6 +172,7 @@ def __init__(
         if trace_dir is not None:
             try:
                 from epistemic.trace import TraceVault
+
                 self._vault = TraceVault(trace_dir)
             except ImportError:
                 pass
@@ -379,6 +380,7 @@ def seal(
         if self._vault is None:
             return None
         from epistemic.trace import TraceVault  # type: ignore[attr-defined]
+
         vault: TraceVault = self._vault  # type: ignore[assignment]
         ids = artifact_ids or [a.artifact_id for a in self._artifacts]
         return vault.seal(
@@ -393,6 +395,7 @@ def verify_trace(self) -> tuple[bool, list[str]]:
         if self._vault is None:
             return True, []
         from epistemic.trace import TraceVault  # type: ignore[attr-defined]
+
         vault: TraceVault = self._vault  # type: ignore[assignment]
         return vault.verify()