Skip to content

Deployment preview updated#185

Open
varsha-0007 wants to merge 2 commits intolayer5io:masterfrom
varsha-0007:deployment-preview-updated
Open

Deployment preview updated#185
varsha-0007 wants to merge 2 commits intolayer5io:masterfrom
varsha-0007:deployment-preview-updated

Conversation

@varsha-0007
Copy link
Copy Markdown

Notes for Reviewers
This PR fixes the deployment issue in #174
Related to #180

Signed commits

  • Yes, I signed my commits.

…_EDITMSG.swpci: add deployment preview workflow

Signed-off-by: varsha <varsha.narvi.07@gmail.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Signed-off-by: varsha <varsha.narvi.07@gmail.com>
@varsha-0007
Copy link
Copy Markdown
Author

Hi,
could a maintainer kindly approve the workflow run when you get a chance?
Thank you! 🙏

Copy link
Copy Markdown
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this workflow with your fork ?

@varsha-0007
Copy link
Copy Markdown
Author

Hey @Rajesh-Nagarajan-11,
Since it's a deployment workflow requiring Netlify credentials, I couldn't test it locally. I based it on the workflow from layer5io/docs and adapted it for this repo. Happy to make changes if needed!

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

This PR is for Gh-pages deployment right ? , we don't need netlify cred for this

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

@varsha-0007
Copy link
Copy Markdown
Author

Hey @Rajesh-Nagarajan-11!
Checked the link, step 8 is throwing a 403 permission denied error for github-actions[bot] while trying to push. I think the workflow needs read and write permissions enabled in the repo settings. Am I right? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants