Fix favicon 86#223
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the favicon paths in layouts/partials/favicon.html to use the relURL helper, and attempts to upgrade the Go version to 1.26 in both the Makefile and go.mod. However, Go 1.26 is not a released version, which will cause build and toolchain resolution failures. The reviewer recommends reverting or using a valid, released Go version such as 1.24.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
🚀 Preview deployment: https://layer5io.github.io/academy-theme/pr-preview/pr-223/ |
Signed-off-by: Parth Gartan <parthgartan26feb@gmail.com>
28a5500 to
ab638ee
Compare
Notes for Reviewers
I updated layouts/partials/favicon.html to properly wrap all image paths in Hugo's relURL function (e.g., href='{{ "favicons/favicon.ico" | relURL }}') and removed the leading slashes.
This ensures that Hugo dynamically resolves the correct favicon path regardless of the deployment baseURL or subdirectory, allowing the browser to successfully load the Layer5 "5" logos that are already bundled in the theme.
This PR fixes #86
Signed commits