Skip to content

Fix favicon 86#223

Open
PARTH-TUSSLE wants to merge 1 commit into
layer5io:masterfrom
PARTH-TUSSLE:fix-favicon-86
Open

Fix favicon 86#223
PARTH-TUSSLE wants to merge 1 commit into
layer5io:masterfrom
PARTH-TUSSLE:fix-favicon-86

Conversation

@PARTH-TUSSLE

Copy link
Copy Markdown
Contributor

Notes for Reviewers

I updated layouts/partials/favicon.html to properly wrap all image paths in Hugo's relURL function (e.g., href='{{ "favicons/favicon.ico" | relURL }}') and removed the leading slashes.

This ensures that Hugo dynamically resolves the correct favicon path regardless of the deployment baseURL or subdirectory, allowing the browser to successfully load the Layer5 "5" logos that are already bundled in the theme.

{D31DAD8D-9158-4058-9255-5771B296689E}

This PR fixes #86

Signed commits

  • [✅ ] Yes, I signed my commits.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the favicon paths in layouts/partials/favicon.html to use the relURL helper, and attempts to upgrade the Go version to 1.26 in both the Makefile and go.mod. However, Go 1.26 is not a released version, which will cause build and toolchain resolution failures. The reviewer recommends reverting or using a valid, released Go version such as 1.24.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .github/build/Makefile.core.mk Outdated
Comment thread go.mod Outdated
@github-actions

Copy link
Copy Markdown

🚀 Preview deployment: https://layer5io.github.io/academy-theme/pr-preview/pr-223/

Signed-off-by: Parth Gartan <parthgartan26feb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Favicon to Layer5 Favicon

1 participant