Skip to content

Commit 1a69648

Browse files
committed
fix: set max-height to none on sidebar nav to resolve clipping
This elegantly overrides the upstream Docsy theme constraint, allowing the parent wrapper to handle scrolling natively without needing to duplicate or move upstream SCSS files. Signed-off-by: yashnagar67 <nitwalababaji@gmail.com>
1 parent 2b9ac3b commit 1a69648

2 files changed

Lines changed: 177 additions & 0 deletions

File tree

assets/scss/_sidebar-tree.scss

Lines changed: 176 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,176 @@
1+
.td-sidebar-nav {
2+
$_max-height: calc(100vh - 8.5rem);
3+
4+
padding-right: 0.5rem;
5+
margin-right: -15px;
6+
margin-left: -15px;
7+
8+
// @include media-breakpoint-up(md) {
9+
// @supports (position: sticky) {
10+
// max-height: $_max-height;
11+
// overflow-y: auto;
12+
// }
13+
// }
14+
15+
// Adjust height and padding when sidebar_search_disable is true, but only for
16+
// >= `lg` views, because on tablet (`md`) and mobile (<= `sm`), the search
17+
// box is displayed regardless of the value of sidebar_search_disable:
18+
&.td-sidebar-nav--search-disabled {
19+
@include media-breakpoint-up(lg) {
20+
// There's no search box so add top padding
21+
// and adjust max-height:
22+
padding-top: 1rem;
23+
24+
@supports (position: sticky) {
25+
max-height: calc(#{$_max-height} + 4.5rem);
26+
}
27+
}
28+
}
29+
30+
@include media-breakpoint-up(md) {
31+
display: block !important;
32+
}
33+
34+
&__section {
35+
li {
36+
list-style: none;
37+
}
38+
39+
&.ul-0, ul {
40+
padding: 0;
41+
margin: 0;
42+
}
43+
44+
@include media-breakpoint-up(md) {
45+
& .ul-1 ul {
46+
padding-left: 1.5em;
47+
}
48+
}
49+
50+
padding-left: 0;
51+
}
52+
53+
&__section-title {
54+
display: block;
55+
font-weight: $font-weight-medium;
56+
57+
.active {
58+
font-weight: $font-weight-bold;
59+
}
60+
61+
a {
62+
color: var(--bs-secondary-color);
63+
}
64+
}
65+
66+
.td-sidebar-link {
67+
display: block;
68+
padding-bottom: 0.375rem;
69+
70+
&__page {
71+
color: var(--bs-body-color);
72+
font-weight: $font-weight-light;
73+
}
74+
}
75+
76+
a {
77+
&:focus,
78+
&:hover {
79+
color: var(--bs-link-color);
80+
}
81+
82+
&.active {
83+
font-weight: $font-weight-bold;
84+
}
85+
}
86+
87+
.dropdown {
88+
a {
89+
color: var(--bs-tertiary-color);
90+
}
91+
92+
.nav-link {
93+
padding: 0 0 1rem;
94+
}
95+
}
96+
97+
& > .td-sidebar-nav__section {
98+
padding-left: 1.5rem;
99+
}
100+
101+
li i {
102+
// Layout of icons
103+
padding-right: 0.5em;
104+
&:before {
105+
display: inline-block;
106+
text-align: center;
107+
min-width: 1em;
108+
}
109+
}
110+
111+
.td-sidebar-link.tree-root {
112+
font-weight: $font-weight-bold;
113+
border-bottom: 1px solid #ccc;
114+
margin-bottom: 1rem;
115+
}
116+
}
117+
118+
.td-sidebar {
119+
@include link-decoration;
120+
121+
@include media-breakpoint-up(md) {
122+
padding-top: 4rem;
123+
background-color: var(--bs-body-tertiary-bg);
124+
padding-right: 1rem;
125+
border-right: 1px solid var(--bs-border-color);
126+
}
127+
128+
padding-bottom: 1rem;
129+
130+
&__toggle {
131+
line-height: 1;
132+
color: var(--bs-body-color);
133+
margin: 1rem;
134+
}
135+
136+
&__search {
137+
padding: 1rem 0;
138+
}
139+
140+
&__inner {
141+
order: 0;
142+
143+
// @include media-breakpoint-up(md) {
144+
// @supports (position: sticky) {
145+
// position: sticky;
146+
// top: 4rem;
147+
// z-index: 10;
148+
// height: calc(100vh - 5rem);
149+
// }
150+
// }
151+
152+
@include media-breakpoint-up(xl) {
153+
flex: 0 1 320px;
154+
}
155+
156+
.td-search-box {
157+
width: 100%;
158+
}
159+
}
160+
161+
#content-desktop {
162+
display: block;
163+
}
164+
#content-mobile {
165+
display: none;
166+
}
167+
168+
@include media-breakpoint-down(lg) {
169+
#content-desktop {
170+
display: none;
171+
}
172+
#content-mobile {
173+
display: block;
174+
}
175+
}
176+
}

assets/scss/_styles_project.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ a:not([href]):not([class]):hover {
262262

263263
// Left sidebar
264264
.td-sidebar-nav {
265+
max-height: none;
265266
overflow: hidden;
266267
padding: 0px;
267268

0 commit comments

Comments
 (0)