docs: add description and default permissions for team manager role#1087
docs: add description and default permissions for team manager role#1087Mahesh-Nandigam wants to merge 7 commits into
Conversation
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces the 'Team Manager' role across the documentation and authorization configuration. Specifically, it adds details for the 'Team Manager' role in the roles documentation and updates the authorization CSV files (keys.csv and keys-backup.csv) to include permissions for this new role. The feedback highlights a typo in the column headers of keys.csv ('Leaner' instead of 'Learner') and suggests minor grammatical and casing corrections in the 'Team Manager' role documentation to ensure consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1087/
|
…es.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MAHESH NANDIGAM <nandigammahesh595@gmail.com>
…es.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: MAHESH NANDIGAM <nandigammahesh595@gmail.com>
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
|
@Mahesh-Nandigam Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
Hi @Bhumikagarggg, thank you! I have my college lab external exam tomorrow, so I won't be able to join the call this week. I would love to join next week's call instead to discuss the PR! I will add it to the minutes for next week. |
KatalKavya96
left a comment
There was a problem hiding this comment.
Thanks @Mahesh-Nandigam for working on this.
Before reviewing further, could you please clarify where the Team Manager default permissions were taken from? Since this is permissions-related documentation, we should confirm the source of truth and avoid assuming from another role.
Also, the preview deployment has been pruned. Could you please push a small commit or re-trigger the preview so we can verify the generated docs page visually?
One more thing: I am not sure if we want to add the full Team Manager role description in this PR or only update its default permissions as mentioned in the original issue.
@Bharath314 could you please confirm whether adding the Team Manager role card here is required, or should this PR stay limited to the default permissions update?
|
@NSTKrishna review, please. Collaborate with the author until this is merged. |
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
Hey @KatalKavya96 , I'm not a maintainer. I'm just a contributor and I was going through the docs and thought I saw a gap in the documentation and so raised an issue. I'd say it is up to the maintainers to decide what they want from this PR. But since it's just copy-pasted content from this page, my opinion is that this change is small enough to be allowed to slip through. |
|
hey @KatalKavya96, i just pushed a new commit, so the deploy preview should start building now. for the permissions, i took them from _index.md on the roles page (here: https://github.com/layer5io/docs/blob/master/content/en/cloud/concepts/identity-and-security/roles/_index.md). it defines the team manager role as 'Administration of teams (without delete access)'. so i mirrored the team administrator permissions but left the delete team permission blank. (I've attached the screenshot of the roles overview diagram from the docs below showing the Team Managers box). about the card in team-roles.md—i agree with @Bharath314 that keeping it makes the two pages consistent, but if you prefer to keep this PR strictly about the default permissions table, i'm happy to revert the card changes. let me know what you and @Bharath314 prefer.
|
There was a problem hiding this comment.
Thanks for the PR! The updates to the role cards in roles/_index.md and team-roles.md look good.
A couple of things to consider:
-
keys.csvis auto-generated
Thekeys.csvfile is updated daily from the Google Sheet through thegenerate-keys.ymlworkflow. Since "Team Manager" is not currently present in the sheet, these changes will be overwritten the next time the workflow runs. -
The role is not implemented yet
As far as I can tell, the "Team Manager" role has not yet been implemented in the backend/database.
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
|
@rishiraj38 ah got it, my bad. i didn't know keys.csv was auto-generated daily. i've reverted the changes to both csv files. i also added the (Coming Soon) label to the Team Manager cards in _index.md and team-roles.md thanks for catching that
|



Hi! This PR fixes #1076 by documenting the missing Team Manager role and adding its default permissions.
Here is what I've changed:
team-roles.md._index.md) to the default permissions page.Team Managercolumn tokeys.csvandkeys-backup.csv. The permissions mirror the Team Admin role but without the ability to delete teams.Here are the before and after screenshots for review:
Default Team Roles Page:
Default Permissions Table:
Let me know if this looks good. Closes #1076