Skip to content

docs: add description and default permissions for team manager role#1087

Open
Mahesh-Nandigam wants to merge 7 commits into
layer5io:masterfrom
Mahesh-Nandigam:fix-team-manager-permissions
Open

docs: add description and default permissions for team manager role#1087
Mahesh-Nandigam wants to merge 7 commits into
layer5io:masterfrom
Mahesh-Nandigam:fix-team-manager-permissions

Conversation

@Mahesh-Nandigam

Copy link
Copy Markdown
Contributor

Hi! This PR fixes #1076 by documenting the missing Team Manager role and adding its default permissions.

Here is what I've changed:

  1. Added the Team Manager role description card to team-roles.md.
  2. Linked the Team Manager card header in the roles index page (_index.md) to the default permissions page.
  3. Added the Team Manager column to keys.csv and keys-backup.csv. The permissions mirror the Team Admin role but without the ability to delete teams.

Here are the before and after screenshots for review:

Default Team Roles Page:

  • Before (Only Team Administrator listed):
Screenshot 2026-06-07 113507
  • After (Both Team Administrator and Team Manager listed):
Screenshot 2026-06-07 120535

Default Permissions Table:

  • Before (No column for Team Manager):
Screenshot 2026-06-07 113413
  • After (Team Manager column added):
Screenshot 2026-06-07 120552

Let me know if this looks good. Closes #1076

Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the 'Team Manager' role across the documentation and authorization configuration. Specifically, it adds details for the 'Team Manager' role in the roles documentation and updates the authorization CSV files (keys.csv and keys-backup.csv) to include permissions for this new role. The feedback highlights a typo in the column headers of keys.csv ('Leaner' instead of 'Learner') and suggests minor grammatical and casing corrections in the 'Team Manager' role documentation to ensure consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread static/data/csv/keys.csv Outdated
Comment thread content/en/cloud/concepts/identity-and-security/roles/team-roles.md Outdated
Comment thread content/en/cloud/concepts/identity-and-security/roles/team-roles.md Outdated
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1087/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Mahesh-Nandigam and others added 3 commits June 7, 2026 12:18
…es.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: MAHESH NANDIGAM <nandigammahesh595@gmail.com>
…es.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: MAHESH NANDIGAM <nandigammahesh595@gmail.com>
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
@Bhumikagarggg

Copy link
Copy Markdown
Contributor

@Mahesh-Nandigam Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

@Mahesh-Nandigam

Copy link
Copy Markdown
Contributor Author

Hi @Bhumikagarggg, thank you! I have my college lab external exam tomorrow, so I won't be able to join the call this week. I would love to join next week's call instead to discuss the PR! I will add it to the minutes for next week.

@KatalKavya96 KatalKavya96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mahesh-Nandigam for working on this.

Before reviewing further, could you please clarify where the Team Manager default permissions were taken from? Since this is permissions-related documentation, we should confirm the source of truth and avoid assuming from another role.

Also, the preview deployment has been pruned. Could you please push a small commit or re-trigger the preview so we can verify the generated docs page visually?

One more thing: I am not sure if we want to add the full Team Manager role description in this PR or only update its default permissions as mentioned in the original issue.
@Bharath314 could you please confirm whether adding the Team Manager role card here is required, or should this PR stay limited to the default permissions update?

@hortison hortison requested a review from rishiraj38 June 11, 2026 03:19
@hortison

Copy link
Copy Markdown
Contributor

@NSTKrishna review, please. Collaborate with the author until this is merged.

Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
@Bharath314

Copy link
Copy Markdown
Contributor

One more thing: I am not sure if we want to add the full Team Manager role description in this PR or only update its default permissions as mentioned in the original issue. @Bharath314 could you please confirm whether adding the Team Manager role card here is required, or should this PR stay limited to the default permissions update?

Hey @KatalKavya96 , I'm not a maintainer. I'm just a contributor and I was going through the docs and thought I saw a gap in the documentation and so raised an issue. I'd say it is up to the maintainers to decide what they want from this PR. But since it's just copy-pasted content from this page, my opinion is that this change is small enough to be allowed to slip through.

@Mahesh-Nandigam

Mahesh-Nandigam commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

hey @KatalKavya96,

i just pushed a new commit, so the deploy preview should start building now.

for the permissions, i took them from _index.md on the roles page (here: https://github.com/layer5io/docs/blob/master/content/en/cloud/concepts/identity-and-security/roles/_index.md). it defines the team manager role as 'Administration of teams (without delete access)'. so i mirrored the team administrator permissions but left the delete team permission blank. (I've attached the screenshot of the roles overview diagram from the docs below showing the Team Managers box).

about the card in team-roles.md—i agree with @Bharath314 that keeping it makes the two pages consistent, but if you prefer to keep this PR strictly about the default permissions table, i'm happy to revert the card changes. let me know what you and @Bharath314 prefer.

image

@rishiraj38 rishiraj38 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The updates to the role cards in roles/_index.md and team-roles.md look good.

A couple of things to consider:

  1. keys.csv is auto-generated
    The keys.csv file is updated daily from the Google Sheet through the generate-keys.yml workflow. Since "Team Manager" is not currently present in the sheet, these changes will be overwritten the next time the workflow runs.

  2. The role is not implemented yet
    As far as I can tell, the "Team Manager" role has not yet been implemented in the backend/database.

Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
Signed-off-by: Mahesh Nandigam <nandigammahesh595@gmail.com>
@rishiraj38 rishiraj38 requested a review from PragalvaXFREZ June 11, 2026 13:33
@Mahesh-Nandigam

Copy link
Copy Markdown
Contributor Author

@rishiraj38 ah got it, my bad. i didn't know keys.csv was auto-generated daily. i've reverted the changes to both csv files.

i also added the (Coming Soon) label to the Team Manager cards in _index.md and team-roles.md

thanks for catching that

Screenshot 2026-06-11 190048 Screenshot 2026-06-11 190014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Team Manager role doesn't have default permissions

6 participants