Skip to content

[CI] Migrate to npm-managed local Hugo and standardise Makefile targets#1096

Open
hebypaul wants to merge 2 commits into
layer5io:masterfrom
hebypaul:feature/hebypaul/1093
Open

[CI] Migrate to npm-managed local Hugo and standardise Makefile targets#1096
hebypaul wants to merge 2 commits into
layer5io:masterfrom
hebypaul:feature/hebypaul/1093

Conversation

@hebypaul

Copy link
Copy Markdown
Contributor

Notes for Reviewers
This PR updates the local development environment to use an npm-managed version of Hugo (extended) and standardizes the Makefile targets. This streamlines the setup process by removing the need for contributors to globally install Hugo and PostCSS on their local machines.

This PR fixes #1093

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Heby T Paul <hebytpaul1111@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation and build process to manage the extended Hugo version and PostCSS dependencies automatically via npm. It introduces a dependency check in the Makefile and wraps Hugo commands in npm scripts. The review feedback points out an inefficiency in the clean target of the Makefile, where running npm run dev:clean triggers an unnecessary full build before running make site. It is recommended to use the existing npm run clean script instead, which directly removes build artifacts, and consequently remove the redundant dev:clean script from package.json.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Makefile Outdated
Comment thread package.json Outdated
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1096/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Signed-off-by: Heby T Paul <hebytpaul1111@gmail.com>

@hortison hortison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please confirm that the makefile here is exactly the same as in GitHub.com/meshery-extensions/meshery-academy and in GitHub.com/meshery/meshery.

@hebypaul

Copy link
Copy Markdown
Contributor Author

Thanks! Please confirm that the makefile here is exactly the same as in GitHub.com/meshery-extensions/meshery-academy and in GitHub.com/meshery/meshery.

The core standardized targets (check-deps, site, serve) now use the exact same npm scripts across all three repositories. However, an exact byte-for-byte match isn't possible because each Makefile retains its own project-specific targets, such as the Docker builds in meshery/meshery and theme updates in meshery-academy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Migrate to npm-managed local Hugo and standardise Makefile targets

2 participants