Clarify comment notification behavior #923
Closed
Bhumikagarggg wants to merge 10 commits intolayer5io:masterfrom
Closed
Clarify comment notification behavior #923Bhumikagarggg wants to merge 10 commits intolayer5io:masterfrom
Bhumikagarggg wants to merge 10 commits intolayer5io:masterfrom
Conversation
… in Kanvas docs Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
leecalcote
reviewed
Mar 28, 2026
leecalcote
requested changes
Mar 28, 2026
leecalcote
reviewed
Apr 4, 2026
leecalcote
reviewed
Apr 4, 2026
Consolidate notification instructions for design comments. Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
|
Bhumikagarggg
changed the title
leecalcote
added a commit
that referenced
this pull request
Apr 29, 2026
…mbedded designs and support page embed from PR #807; clarify comment notification behavior from PR #923 - sharing-a-workspace.md: Add 'Share without publishing' section before Publish section; add alert clarifying Published vs Public distinction and public design permissions - support.md: Replace static account recovery image with embedded interactive Meshery design - static/export-designs/: Add embedded-design-account-recovery.js and embedded-design-kanvas.js for interactive embeds - comments/index.md: Fix typos (recieve→receive, notificaiton→notification, 'into the your'); combine single-sentence paragraphs into fuller prose; replace plain notes with alert shortcodes for collaborator notifications, thread-level muting behavior, global notification preferences, and muted/missed notification reminders; clarify 'New Comment Threads' muting behavior Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Member
|
Thank you @Bhumikagarggg! The improvements from this PR have been incorporated into master: fixed typos (recieve→receive, notificaiton→notification), consolidated single-sentence paragraphs, and added alert shortcodes for collaborator notifications and thread-level muting behavior (commit 25926e2). Closing as the content has been applied with the stylistic refinements requested in review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
owner-specific muting rules in Kanvas docs
Notes for Reviewers
This PR fixes #922
Signed commits