Skip to content

fix: improve right sidebar ToC hover contrast #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kavyakapoor420 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

fix: improve right sidebar ToC hover contrast #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/scss/_styles_project.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,14 @@ a:not([href]):not([class]):hover {
#TableOfContents {
a {
color: $lightslategray;
padding: 0.25rem 0.5rem;
border-radius: 4px;
transition: background-color 0.2s ease;
Comment on lines +382 to +384
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To ensure the padding and background color are applied correctly and provide a consistent hit area, the anchor tags should be set to display: block. Additionally, the transition should include the color property to match the background transition. Finally, although the PR description mentions adding focus-visible styles, they are missing from the implementation; adding them here ensures accessibility for keyboard users.

      display: block;
      padding: 0.25rem 0.5rem;
      border-radius: 4px;
      transition: all 0.2s ease;

      &:focus-visible {
        color: $white;
        text-decoration: none;
        background-color: rgba($primary, 0.15);
      }


&:hover {
color: $white;
text-decoration: none;
background-color: rgba($primary, 0.15);
Copy link
Copy Markdown
Member

@Sbragul26 Sbragul26 Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix can be kept simpler. Since the issue is only about hover text visibility adding background-color: rgba($primary, 0.15) in &:hover is enough. The changes in lines 382–384 seem unrelated to this issue.

}
}
}
Expand Down
Loading