[Docs] Add Dialog component with overview, guidance, and code examples#6605
Conversation
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Here's the clue that you're looking for - https://github.com/layer5io/layer5/actions/runs/16073904323/job/45364514434?pr=6605#step:3:137
…s #9305 Signed-off-by: Ayush More <ayushmore42595@gmail.com>
Ayushmore1214
force-pushed
the
add/dialog-component-v2
branch
from
ab29e3f to
2dbe72a
Compare
|
🚀 Preview for commit 2dbe72a at: https://6868702f74ef27512235a9a1--layer5.netlify.app |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
|
🚀 Preview for commit 9d5d52e at: https://686917a274ef27dfa235a90e--layer5.netlify.app |
|
@Ayushmore1214 , looks good. Nice job!!! |
|
Sure @vr-varad I'll make changes soon |
sudhanshutech
left a comment
sudhanshutech
left a comment
There was a problem hiding this comment.
@Ayushmore1214 please take a look at failing check otherwise looks good. @vr-varad i don't think we need for now more examples, we already have the modal component documented so @Ayushmore1214 you can point or redirect to that component if required as example. what say @vr-varad ?
|
Okayy , Give me some time |
|
Hi @sudhanshutech can you provide the correct link or file path for the documented modal component you’re referring to? |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
|
🚀 Preview for commit a74d358 at: https://686e6df8b55bae5716c3b480--layer5.netlify.app |
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
|
🚀 Preview for commit ec14ac4 at: https://686e72cec9bfde53a37252cf--layer5.netlify.app |
|
@vr-varad I have made changes as you asked plz have a look at them |
|
🚀 Preview for commit af10ec8 at: https://6874a718457edda08240eaa5--layer5.netlify.app |
|
Thank you @Ayushmore1214 for your contribution. |
|
Welcome @vr-varad ! |
5 participants
Description
This PR fixes #6598
Notes for Reviewers
Signed commits