Fix(sistent): added ClickAwayListener component documentation#7673
Fix(sistent): added ClickAwayListener component documentation#7673kanishksingh23 wants to merge 2 commits intolayer5io:masterfrom
Conversation
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7673/
|
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
Why its empty ?
please fix this .
There was a problem hiding this comment.
Please add the imports in the codeBlock
There was a problem hiding this comment.
Hi @rishiraj38, I have addressed both issues in the latest commits. Please let me know if any further changes are needed.
|
@rishiraj38 gentle ping |
|
@Rajesh-Nagarajan-11, please review this. |
|
@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@rishiraj38, gentle ping |
| /> | ||
| </div> | ||
|
|
||
| <a id="Custom events"> |
There was a problem hiding this comment.
Where is the Example Preview ?
There was a problem hiding this comment.
@rishiraj38, I have added the example previews for the Custom events and Dismissible UI patterns.
| </div> | ||
|
|
||
| <a id="Dismissible UI patterns"> | ||
| <h2>Dismissible UI patterns</h2> |
There was a problem hiding this comment.
Same for this where is the example preview please if you have confusion please checkout other components code examples
| <p style={{ margin: 0 }}> | ||
| This pattern is ideal for keeping a small panel open until the user clicks away. | ||
| </p> | ||
| <Button variant="outlined" style={{ marginTop: "1rem" }}> |
There was a problem hiding this comment.
Could you please explain why this is included in the guidance?
|
@Rajesh-Nagarajan-11 Thanks For the Preview |
|
@rishiraj38, I have addressed all the comments. Please take a look. |
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
It’s much better now. There’s a small issue in light mode: the box content is visible but not in dark mode. Could you please fix that too?
|
@rishiraj38, done. Please take a look and inform if any changes are there to make. |
The problem persists. Please check the preview. |
@rishiraj38, done |
|
Also fix the overview section component. |
|
Hi @rishiraj38, I have fixed the dark mode issue in the overview section as well. Hope this time everything goes well 🙂. |
|
@kanishksingh23 , the problem still persists |
|
This component also doesn’t function as it says. Please check preview after the fix if all these issues are solved then you can tag us for the next review. 
|
@rishiraj38, now I think every issue is fixed. Please take a look. |
|
One last thing too many commits please squash them |
kanishksingh23
force-pushed
the
fix/add-click-away-listener-docs
branch
from
cba288e to
353bc75
Compare
github-actions
Bot
added
project/meshery
area/community
area/careers
project/kanvas
labels
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
kanishksingh23
force-pushed
the
fix/add-click-away-listener-docs
branch
from
353bc75 to
9333137
Compare
solved |
3 participants
Description
This PR fixes #7668
Added documentation for the ClickAwayListener component to the Sistent components page, including:
index.mdx- Component overview, how it works, and usageguidance.mdx- Best practices and when to usecode.mdx- Live code examples for basic usage, custom events, and dismissible UI patternsNotes for Reviewers
Documentation follows the same structure as existing components (Popper, Tooltip, etc.)
Signed commits