Fix: Added missing images for Kanvas collaborate page#7695
Conversation
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
eebdbaf to
22cd814
Compare
|
Preview deployment for PR #7695 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
@saurabhraghuvanshii, please review this. |
|
@kanishksingh23 Please add all images and gif in /static/images and also update page. |
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
@saurabhraghuvanshii, I have addressed your comment. |
There was a problem hiding this comment.
@kanishksingh23 it is good but can you please put these images into static/images/kanavs-collaborate ? that will be maintainable.
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
@saurabhraghuvanshii, gentle ping |
|
@kanishksingh23 your changes are not visible https://layer5.io/pr-preview/pr-7695/cloud-native-management/kanvas/collaborate. Please take a look |
I will look into this. |
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
|
@saurabhraghuvanshii, the images are now loading correctly on the preview. Please take a look: https://layer5.io/pr-preview/pr-7695/cloud-native-management/kanvas/collaborate |
|
Thanks @kanishksingh23 lgtm!! |
|
Thank you @saurabhraghuvanshii, for the quick review. |
Description
Adds the four images that were already imported in
collaboration-feature-team.jsbut were missing from the repo, causing the Kanvas collaborate page to be incomplete.
This PR fixes #6609
Changes made:
conversation.pngcomponents.gifactivity-logs.pngundo-redo.pngNotes for Reviewers
collaboration-feature-team.jsbut never committed to the repo, which is why the page appeared incomplete.
CollaborationFeatureCreatecomponent exists but is commented out inindex.jsCollaborationFeatureWorkhas world transition images commented outSigned commits