Add validation for markDirty and SetMeasureFunc

heoblitz · heoblitz · commit 649c7348ca46 · 2025-10-15T22:53:35.000+09:00
diff --git a/Sources/YogaKit/YGLayout.mm b/Sources/YogaKit/YGLayout.mm
@@ -227,7 +227,7 @@ - (void)markDirty {
   // the measure function. Since we already know that this is a leaf,
   // this *should* be fine. Forgive me Hack Gods.
   const YGNodeRef node = self.node;
-  if (!YGNodeHasMeasureFunc(node)) {
+  if (!YGNodeHasMeasureFunc(node) && self.numberOfChildren == 0) {
     YGNodeSetMeasureFunc(node, YGMeasureView);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ - (void)markDirty {`
`227`	`227`	`// the measure function. Since we already know that this is a leaf,`
`228`	`228`	`// this should be fine. Forgive me Hack Gods.`
`229`	`229`	`const YGNodeRef node = self.node;`
`230`		`- if (!YGNodeHasMeasureFunc(node)) {`
	`230`	`+ if (!YGNodeHasMeasureFunc(node) && self.numberOfChildren == 0) {`
`231`	`231`	`YGNodeSetMeasureFunc(node, YGMeasureView);`
`232`	`232`	`}`
`233`	`233`