Add Debian and UBI image flavours#4
Open
pascal-zarrad wants to merge 2 commits into
Open
Conversation
Use bash array for find arguments instead of building a string. The unquoted glob pattern *.log was subject to shell expansion when .log files existed in the container CWD, causing find to discover all files regardless of LOG_FILE_ENDINGS setting.
Introduce Containerfile.debian (bookworm-slim) and Containerfile.ubi (UBI 9 minimal) alongside the existing Alpine image. Alpine remains the default with no tag suffix for backwards compatibility. Ofelia and tini are musl-linked, so Debian and UBI images copy the musl dynamic linker from Alpine. UBI uses a builder stage for tini. All CI workflows use matrix strategies to build, test, and publish all three flavours in parallel. Tag convention: 1.2.3, 1.2.3-debian, 1.2.3-ubi.
pascal-zarrad
force-pushed
the
feature/log-file-endings
branch
from
March 14, 2026 23:41
6a97970 to
599b8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces multi-flavour support for the logrotate container, adding dedicated builds and CI/CD pipelines for Alpine, Debian, and UBI (Red Hat) base images. The CI/CD workflows and documentation are updated to reflect this, and the E2E test runner is enhanced to test all flavours. The most important changes are outlined below.
Containerization: Multi-flavour support
Containerfile.alpine,Containerfile.debian, andContainerfile.ubi, each tailored to their respective base images and package managers. This enables building images for Alpine, Debian, and UBI (Red Hat) distributions. [1] [2] [3].dockerignoreto include new build and documentation files, ensuring cleaner build contexts.CI/CD and Build Pipeline Updates
build_edge.ymlandbuild_production.ymlworkflows to build and tag images for all three flavours using a matrix strategy, and to apply appropriate tag suffixes (-debian,-ubi, or none for Alpine). [1] [2] [3] [4]e2e.ymlworkflow to run E2E tests for each flavour, ensuring all variants are tested in CI. [1] [2]E2E Test Runner Improvements
e2e/run-tests.shto accept aCONTAINERFILEenvironment variable for specifying which Dockerfile/flavour to test, and to display the tested flavour in both console output and GitHub step summary. [1] [2] [3]Documentation Updates
CLAUDE.mdto document the new multi-flavour build process, usage instructions, CI/CD conventions, and tag suffixes for each flavour. [1] [2] [3] [4]