Skip to content

use paymentAdjustment in the fixed leg#2649

Open
jmishin wants to merge 1 commit into
lballabio:masterfrom
jmishin:feature/paymentAdjustment
Open

use paymentAdjustment in the fixed leg#2649
jmishin wants to merge 1 commit into
lballabio:masterfrom
jmishin:feature/paymentAdjustment

Conversation

@jmishin

@jmishin jmishin commented Jul 7, 2026

Copy link
Copy Markdown

paymentAdjustment is ignored for the fixed leg in OvernightIndexedSwap
see example below:

import QuantLib as ql

today = ql.Date(27,2,2026)
ql.Settings.instance().evaluationDate = today

value_date = ql.Russia().advance(today, 1, ql.Days)
maturiry_date = ql.NullCalendar().advance(value_date, 3, ql.Years)

schedule = ql.MakeSchedule(
effectiveDate=value_date,
terminationDate=maturiry_date,
tenor=ql.Period("3Y"),
frequency=ql.Monthly,
calendar=ql.NullCalendar(), #IMPORTANT
convention=ql.Unadjusted, #IMPORTANT
rule=ql.DateGeneration.Forward
)

swap = ql.OvernightIndexedSwap(
ql.Swap.Payer,
1_000,
schedule,
0.0,
ql.ActualActual(ql.ActualActual.ISDA),
ql.Sofr(),
0.0,
0,
ql.ModifiedFollowing, #IMPORTANT
ql.Russia(),
False,
ql.RateAveraging.Compound,
1,
0,
False
)

for c in swap.fixedLeg():
print(f"{c.date().ISO()} {ql.Russia().isBusinessDay(c.date())}")

@CLAassistant

CLAassistant commented Jul 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@boring-cyborg

boring-cyborg Bot commented Jul 7, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@lballabio

Copy link
Copy Markdown
Owner

Thanks! May you have a look at the CLAassistant comment above?

@jmishin

jmishin commented Jul 8, 2026

Copy link
Copy Markdown
Author

Thanks! May you have a look at the CLAassistant comment above?

I signed the CLA, but the problem is that my local git settings contained an email not linked to my GitHub account. It looks like the only way out is to make a new commit. Should I do it now or wait for your review to account for possible revisions?

@coveralls

coveralls commented Jul 8, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 74.885%. remained the same — jmishin:feature/paymentAdjustment into lballabio:master

@lballabio

Copy link
Copy Markdown
Owner

Please go ahead — the PR is simple and the tests are passing, so I don't think I'll require any changes.

@jmishin jmishin force-pushed the feature/paymentAdjustment branch from eb7e89b to 3b4d5c3 Compare July 8, 2026 17:14
@jmishin

jmishin commented Jul 8, 2026

Copy link
Copy Markdown
Author

Please go ahead — the PR is simple and the tests are passing, so I don't think I'll require any changes.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants