FIX upgrade from prior version

Author: lbayle

classes/constants.class.php

@@ -200,8 +200,14 @@ public static function parseConfigFile() {
       self::$bug_resolved_status_threshold = $mantis['bug_resolved_status_threshold'];
       self::$status_enum_workflow = json_decode($mantis['status_enum_workflow'], true); // jsonStr to array
 
-      self::$mantis_db_table_prefix = $mantis['db_table_prefix'];
-      self::$mantis_db_table_suffix = $mantis['db_table_suffix'];
+      if ( !empty($mantis['db_table_prefix'])) {
+         // variable not set: config.ini file is prior to v1.2.1
+         self::$mantis_db_table_prefix = $mantis['db_table_prefix'];
+      }
+      if ( !empty($mantis['db_table_suffix'])) {
+         // variable not set: config.ini file is prior to v1.2.1
+         self::$mantis_db_table_suffix = $mantis['db_table_suffix'];
+      }
       if ( !empty( self::$mantis_db_table_prefix ) && ('_' != substr( self::$mantis_db_table_prefix, -1 )) ) {
          self::$mantis_db_table_prefix .= '_';
       }

config.ini.sample

@@ -61,11 +61,8 @@ max_tooltips_per_page = 500
 logo_image_0207_0214 = "images/codevtt_logo_03_stvalentin.png"
 logo_image_0317_0317 = "images/codevtt_logo_03_stpatrick.jpg"
 logo_image_0401_0401 = "images/codevtt_logo_03_april_1st.jpg"
-logo_image_0421_0425 = "images/codevtt_logo_03_easter.png"
 logo_image_1031_1031 = "images/codevtt_logo_03_halloween.png"
 logo_image_1220_1227 = "images/codevtt_logo_03_christmas.png"
-;logo_image_1231_1231 = "images/codevtt_logo_03_happynewyear.png"
-;logo_image_0101_0106 = "images/codevtt_logo_03_happynewyear.png"
 
 [timesheets]
 ; value:displayed_text

tools/update_codevtt.php

@@ -524,11 +524,6 @@ function update_v16_to_v17() {
    $query5 = "UPDATE `codev_config_table` SET `value`='17' WHERE `config_id`='database_version';";
    execQuery($query5);
 
-   // activate new plugin UserTeamList
-   $query6 = "INSERT INTO `codev_plugin_table` (`name`, `status`, `domains`, `categories`, `version`, `description`) ".
-      "VALUES ('UserTeamList', 1, 'Admin', 'Admin', '1.0.0', 'Display a history of all the teams for a given user');";
-   execQuery($query6);
-
 }
 
 // ======================================================