Fix typing for to_zarr() methods (pydata#10847)

* Fix typing for to_zarr() methods

Fixes pydata#10444

* fix docstring

Author: shoyer

xarray/core/dataarray.py

@@ -118,6 +118,7 @@
         T_ChunkDimFreq,
         T_ChunksFreq,
         T_Xarray,
+        ZarrStoreLike,
     )
     from xarray.groupers import Grouper, Resampler
     from xarray.namedarray.parallelcompat import ChunkManagerEntrypoint
@@ -4253,7 +4254,7 @@ def to_netcdf(
     @overload
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -4277,7 +4278,7 @@ def to_zarr(
     @overload
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -4299,7 +4300,7 @@ def to_zarr(
 
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -4336,7 +4337,7 @@ def to_zarr(
 
         Parameters
         ----------
-        store : MutableMapping, str or path-like, optional
+        store : zarr.storage.StoreLike, optional
             Store or path to directory in local or remote file system.
         chunk_store : MutableMapping, str or path-like, optional
             Store or path to directory in local or remote file system only for Zarr

xarray/core/dataset.py

@@ -167,6 +167,7 @@
         T_Chunks,
         T_DatasetPadConstantValues,
         T_Xarray,
+        ZarrStoreLike,
     )
     from xarray.groupers import Grouper, Resampler
     from xarray.namedarray.parallelcompat import ChunkManagerEntrypoint
@@ -2120,7 +2121,7 @@ def to_netcdf(
     @overload
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -2144,7 +2145,7 @@ def to_zarr(
     @overload
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -2166,7 +2167,7 @@ def to_zarr(
 
     def to_zarr(
         self,
-        store: MutableMapping | str | PathLike[str] | None = None,
+        store: ZarrStoreLike | None = None,
         chunk_store: MutableMapping | str | PathLike | None = None,
         mode: ZarrWriteModes | None = None,
         synchronizer=None,
@@ -2203,7 +2204,7 @@ def to_zarr(
 
         Parameters
         ----------
-        store : MutableMapping, str or path-like, optional
+        store : zarr.storage.StoreLike, optional
             Store or path to directory in local or remote file system.
         chunk_store : MutableMapping, str or path-like, optional
             Store or path to directory in local or remote file system only for Zarr

xarray/core/datatree.py

@@ -91,6 +91,7 @@
         NetcdfWriteModes,
         T_ChunkDimFreq,
         T_ChunksFreq,
+        ZarrStoreLike,
         ZarrWriteModes,
     )
     from xarray.namedarray.parallelcompat import ChunkManagerEntrypoint
@@ -2076,7 +2077,7 @@ def to_netcdf(
     @overload
     def to_zarr(
         self,
-        store,
+        store: ZarrStoreLike,
         mode: ZarrWriteModes = "w-",
         encoding=None,
         consolidated: bool = True,
@@ -2091,7 +2092,7 @@ def to_zarr(
     @overload
     def to_zarr(
         self,
-        store,
+        store: ZarrStoreLike,
         mode: ZarrWriteModes = "w-",
         encoding=None,
         consolidated: bool = True,
@@ -2103,7 +2104,7 @@ def to_zarr(
 
     def to_zarr(
         self,
-        store,
+        store: ZarrStoreLike,
         mode: ZarrWriteModes = "w-",
         encoding=None,
         consolidated: bool = True,
@@ -2117,7 +2118,7 @@ def to_zarr(
 
         Parameters
         ----------
-        store : MutableMapping, str or Path, optional
+        store : zarr.storage.StoreLike
             Store or path to directory in file system
         mode : {{"w", "w-", "a", "r+", None}, default: "w-"
             Persistence mode: “w” means create (overwrite if exists); “w-” means create (fail if exists);