Skip to content

Fix setup-python for Python 3.14 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbliii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix setup-python for Python 3.14 #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/python-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- uses: astral-sh/setup-uv@v7
with:
python-version: "3.14t"
allow-prereleases: true
Comment on lines 24 to +27
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says allow-prereleases: true was added to all actions/setup-python@v6 and astral-sh/setup-uv@v7 steps, but this change only updates the publish workflow (and the composite action). There are other workflows still using these actions without allow-prereleases (e.g., .github/workflows/tests.yml, pages.yml, benchmark-baseline.yml, amp-review.yml, ty.yml). Either update the remaining workflows or adjust the PR description to match the actual scope.

Copilot uses AI. Check for mistakes.

- name: Cache uv dependencies
uses: actions/cache@v5
Expand Down Expand Up @@ -58,6 +59,7 @@ jobs:
- uses: actions/setup-python@v6
with:
python-version: "3.14t"
allow-prereleases: true

- name: Build release distributions
run: |
Expand Down
1 change: 1 addition & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ runs:
uses: actions/setup-python@v6
with:
python-version: ${{ inputs.python-version }}
allow-prereleases: true
Comment on lines 149 to +152
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow-prereleases: true is now hard-coded for all consumers of this composite action, which can make Python resolution less reproducible by allowing pre-release/RC builds even when a stable build exists. Consider exposing this as an action input (defaulting to false) or enabling it conditionally only for versions that need it (e.g., free-threaded *t builds or pre-release tags).

Copilot uses AI. Check for mistakes.

- name: Install kida
if: inputs.install == 'true'
Expand Down
Loading