Integrate location suggestions in context menu#658
Open
kobemertens wants to merge 13 commits into
Open
Conversation
Collaborator
Author
|
Needs this editor PR in order to be able to sticky the "other elements" group to the bottom of the menu. |
This is needed because addresses have the same `belgianAddressUri` regardless how they were created, this is useful for deduplication
abeforgit
requested changes
Jun 3, 2026
Member
abeforgit
left a comment
abeforgit
left a comment
There was a problem hiding this comment.
seems like they're out of order here?
Member
|
note: if I add priority 1 to the location suggestions, the sticky group moves to the bottom, but it seems there isn't really a limit at the moment to how big the suggestion menu gets |
Collaborator
Author
Do you mean in terms of size (height in pixels) or in amount of actions? Because the latter was limited in this commit: |
Collaborator
Author
Should be fixed here: The sticky actions will always be last, regardless of priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Integrates the location suggestions described in https://www.figma.com/design/PbSOBtGdYHBArIjVMEIApP/GN_location-plugin?node-id=46-3621
connected issues and PRs:
https://binnenland.atlassian.net/browse/GN-6164
https://binnenland.atlassian.net/browse/GN-6003
Setup
Needs lblod/ember-rdfa-editor#1377
How to test/reproduce
Add some locations to the document. The contextual actions when clicking on a location should now also suggest other locations in the document. Clicking a suggestion should change the content of the highlighted location node and move the selection forward by one position.
Checks PR readiness