Skip to content

console.log in dev release #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lagartoverde wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −4
Open

console.log in dev release #659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b720e5
console.log in dev release
lagartoverde Jun 5, 2026
384b25d
Revert "console.log in dev release"
lagartoverde Jun 5, 2026
be7ffcf
wait document content on insert
lagartoverde Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions addon/components/common/documents/preview.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import t from 'ember-intl/helpers/t';
import { SayController } from '@lblod/ember-rdfa-editor';
import { PreviewableDocument } from './types';
import { VoteStarUnfilledIcon } from '../vote-star-unfilled-icon';
import perform from 'ember-concurrency/helpers/perform';

interface Signature<Doc extends PreviewableDocument> {
Args: {
Expand All @@ -31,10 +32,10 @@ export default class DocumentPreview<
@tracked controller?: SayController;
@tracked isExpanded = false;

@action
onInsert() {
onInsert = task(async () => {
await this.contentTask.perform();
this.args.onInsert(this.args.doc);
}
});

@action
togglePreview() {
Expand Down Expand Up @@ -101,7 +102,7 @@ export default class DocumentPreview<
<div
role='button'
title={{t 'common.preview-list.select-button.title'}}
{{on 'click' this.onInsert}}
{{on 'click' (perform this.onInsert)}}
{{! template-lint-disable require-presentational-children}}
>
<AuButton class='snippet-preview__insert-button' @skin='naked'>
Expand Down