Feat/headless function#290
Open
lagartoverde wants to merge 5 commits into
Open
Conversation
piemonkey
reviewed
Jun 2, 2026
Contributor
piemonkey
left a comment
There was a problem hiding this comment.
Seems to work well. One thing that feels missing is that there's no feedback on failure. I get that the processing code is taken from GN and that this is missing there, but it would most likely be good to have there too (and maybe that function should move to the editor or plugins repo?
Member
|
One thing to watch out as well is that now you're importing from the plugin repo @lagartoverde could I ask you to do the following as well, in a separate pr:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Make the user able to run headless functions, this combines with the locked placeholder replace function that needs to be run headlessly by CEVI
connected issues and PRs:
lblod/ember-rdfa-editor-lblod-plugins#656
Setup
Check that you can run headless functions in the editor, in order to make the testing easier I built a new page where clicking a button lets you change the besluit type of a besluit headlessly
How to test/reproduce
Go to the new page: headless test, insert a besluit in the besluit textarea, insert a besluit uri in the besluit type input, click on the button notice your besluit type gets changed for the type you inserted
Challenges/uncertainties
Once this PR is approved need to document everything, please if you think something about the API could be improved let me know
Checks PR readiness