Add maxRedirects guard to UrlChecker#20
Merged
Merged
Conversation
26dd60e to
c15c39e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
maxRedirectsguard toUrlCheckerto bound redirect-following.Why
getResponse()followed301/302/307/308redirects recursively with no depth cap and no cycle guard — a redirect loop could recurse until PHP hit its memory/stack limit. The recursive hop also silently dropped the caller'suserAgent/connectTimeout/timeout.Changes
UrlChecker::DEFAULT_MAX_REDIRECTS = 5(untyped, to preserve the package'sphp: ^8.1support — typed class constants are 8.3+).check()gains a trailing, backward-compatible?int $maxRedirects = nullparameter.maxRedirects: 0returns the redirect response without following it.getResponse()threads aredirectsLeftbudget through the recursion, stops once exhausted (returning the last 3xx response), and now preserves the caller's user-agent and timeouts on every hop.Tests
5 new Pest cases: each of
301/302/307/308must terminate (in fake mode every hop re-serves the same response, so without the guard the suite would hang — a genuine regression test), plus amaxRedirects: 0no-follow case.Local gates:
pest17 pass / 29 assertions,phpstan analyseno errors,pint --testpassed.