Merge pull request #490 from weakish/fix-push-test

fix push test

Author: weakish

README.md

@@ -53,10 +53,10 @@ Run tests:
 python -m nose
 ```
 
-Run a single test:
+Run a single test without swallowing print:
 
 ```sh
-python -m nose tests/test_engine.py:test_lean_engine_error
+python -m nose -v --nocapture tests/test_engine.py:test_lean_engine_error
 ```
 
 ## Linter and Formatter

tests/test_push.py

@@ -38,25 +38,30 @@ def test_basic_push():  # type: () -> None
             "launch-image": "",
         }
     }
-    query = leancloud.Query("_Installation").equal_to("objectId", "xxx")
+    query = leancloud.Query("_Installation").equal_to("deviceToken", "xxx")
     now = datetime.now()
     two_hours_later = now + timedelta(hours=2)
-    notification = push.send(
-        data,
-        where=query,
-        push_time=now,
-        expiration_time=two_hours_later,
-        prod="dev",
-        flow_control=0,
-    )
-    # flow_control = 0 <=> flow_control = 1000 by rest api design
-    time.sleep(5)  # notification write may have delay
-    notification.fetch()
-    assert notification.id
-
     try:
-        notification.save()
+        notification = push.send(
+            data,
+            where=query,
+            push_time=now,
+            expiration_time=two_hours_later,
+            prod="dev",
+            flow_control=0,
+        )
     except leancloud.LeanCloudError as e:
+        # LeanCloudError: [1] The iOS certificate file is expired or disabled.
         assert e.code == 1
     else:
-        raise Exception()
+        # flow_control = 0 <=> flow_control = 1000 by rest api design
+        time.sleep(5)  # notification write may have delay
+        notification.fetch()
+        assert notification.id
+        # Test that notification is read only.
+        try:
+            notification.save()
+        except leancloud.LeanCloudError as e:
+            assert e.code == 1
+        else:
+            raise Exception()

tests/test_user.py

@@ -284,7 +284,7 @@ def test_request_change_phone_number():  # type: () -> None
         # phone number is from http://www.z-sms.com
         User.request_change_phone_number("+8617180655340")
     except LeanCloudError as e:
-        if e.code not in (119, 213, 601):
+        if e.code not in (119, 213, 601, 605):
             raise e
     finally:
         user1.logout()