Skip to content

Commit 33f6032

Browse files
authored
Merge pull request #423 from weakish/get-para-typo
fix: typo in get para: deafult -> default
2 parents 081b8cf + aeed0b3 commit 33f6032

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

leancloud/object_.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,18 @@ def validate(self, attrs):
342342
raise TypeError('acl must be a ACL')
343343
return True
344344

345-
def get(self, attr, deafult=None):
345+
def get(self, attr, default=None, deafult=None):
346346
"""
347347
获取对象字段的值
348348
349349
:param attr: 字段名
350350
:type attr: string_types
351351
:return: 字段值
352352
"""
353-
return self._attributes.get(attr, deafult)
353+
# for backward compatibility
354+
if (deafult is not None) and (default is None):
355+
default = deafult
356+
return self._attributes.get(attr, default)
354357

355358
def relation(self, attr):
356359
"""

tests/test_object.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,15 @@ def test_get(): # type: () -> None
9696
assert album.get('foo') == 'bar'
9797

9898

99-
def test_get_deafult(): # type: () -> None
99+
def test_get_default(): # type: () -> None
100100
album = Album()
101101
assert album.get('foo', 'bar') == 'bar'
102+
assert album.get('foo', default='bar') == 'bar'
103+
# for backward compatibility
104+
assert album.get('foo', deafult='bar') == 'bar'
105+
assert album.get('foo', 'bar', deafult='foobar') == 'bar'
106+
assert album.get('foo', deafult='foobar', default='bar') == 'bar'
107+
102108

103109

104110
def test_unset(): # type: () -> None

0 commit comments

Comments
 (0)