Skip to content

Commit a464105

Browse files
authored
Merge pull request #484 from weakish/request-sms-code-mobile-number
feat(sms): phone_number para of request_sms_code supports E.164 format
2 parents 8890947 + ffea30e commit a464105

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

leancloud/cloud.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,9 @@ def request_sms_code(
100100
raise TypeError("phone_number must be a string")
101101

102102
data = {
103-
"mobilePhoneNumber": idd + phone_number,
103+
"mobilePhoneNumber": phone_number
104+
if phone_number.startswith("+")
105+
else idd + phone_number,
104106
"smsType": sms_type,
105107
}
106108

tests/test_engine.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,16 @@ def test_request_sms_code(): # type: () -> None
534534
if leancloud.client.REGION == "US":
535535
return
536536
try:
537-
cloud.request_sms_code("13111111111")
537+
# numbers come from http://www.z-sms.com/
538+
cloud.request_sms_code("+8617180654515")
539+
cloud.request_sms_code("17180654515")
540+
cloud.request_sms_code("17180654515", idd="+86")
541+
cloud.request_sms_code("+8617180654515", idd="+86")
542+
cloud.request_sms_code("+8617180654515", idd="+44") # +8617180654515
543+
cloud.request_sms_code("+447365753569")
544+
cloud.request_sms_code("7365753569", idd="+44")
545+
cloud.request_sms_code("+447365753569", idd="+44")
546+
cloud.request_sms_code("+447365753569", idd="+86") # +447365753569
538547
except LeanCloudError as e:
539548
# 短信发送过于频繁或者欠费或者关闭短信功能
540549
if e.code in (601, 160, 119):

0 commit comments

Comments
 (0)