Merge pull request #496 from leancloud/deprecate-file-api

fix(file): remove deprecated POST /files/:name invocation

Author: weakish

leancloud/file_.py

@@ -245,16 +245,9 @@ def _save_external(self):
             "mime_type": self.mime_type,
             "url": self._url,
         }
-        response = client.post("/files/{0}".format(self._name), data)
+        response = client.post("/files".format(self._name), data)
         content = response.json()
-
-        self._name = content["name"]
-        self._url = content["url"]
         self.id = content["objectId"]
-        if "size" in content:
-            self._metadata["size"] = content["size"]
-        else:
-            raise ValueError
 
     def _save_to_qcloud(self, token, upload_url):
         headers = {

tests/test_file.py

@@ -111,11 +111,15 @@ def test_query():  # type: () -> None
 
 @with_setup(setup_func)
 def test_save_external():  # type: () -> None
-    f = File.create_with_url(
-        "lenna.jpg", "http://i1.wp.com/leancloud.cn/images/static/default-avatar.png"
-    )
+    file_name = "lenna.jpg"
+    file_url = "http://i1.wp.com/leancloud.cn/images/static/default-avatar.png"
+    f = File.create_with_url(file_name, file_url)
     f.save()
     assert f.id
+    file_on_cloud = File.create_without_data(f.id)
+    file_on_cloud.fetch()
+    assert file_on_cloud.name == file_name
+    assert file_on_cloud.url == file_url
 
 
 @raises(ValueError)