Fix --exclude flag

[Kendru98]

Fix for #2991

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the --exclude flag was not being consistently applied across various patrol commands. The changes ensure that the test discovery process correctly honors the exclusion list, preventing specified files or directories from being included in the test run. This improves the precision and reliability of test execution by allowing users to accurately define which tests should be ignored.

Highlights

• Fix --exclude flag functionality: The --exclude flag now correctly filters out specified files and directories when used with patrol build and patrol test commands.
• Improved test finding logic: The TestFinder class was refactored to properly handle exclusion paths, including both individual files and directories, by introducing new helper methods.
• Enhanced test coverage: A new test case was added to ensure that the --exclude flag functions as expected when a directory is provided as a target.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue with the --exclude flag by ensuring it's respected even when explicit test targets are provided. The refactoring within TestFinder is a significant improvement, extracting the exclusion logic into _isExcluded and _toAbsoluteExcludes methods. This enhances code readability, reduces duplication, and makes the logic easier to maintain. The fix is correctly propagated to all relevant commands (build_android, build_ios, build_macos, and test). The addition of a new test case for directory exclusion is also a good step towards ensuring correctness.

[pdenert]

Add changelog

[Kendru98]

Hmm test-ios-simulators failing looks I this change broke something (edit) locally works fine