Skip to content

Add isPlatform getter for all platforms#3061

Merged
dworik merged 7 commits into
masterfrom
feature/is-platform-getter
May 15, 2026
Merged

Add isPlatform getter for all platforms#3061
dworik merged 7 commits into
masterfrom
feature/is-platform-getter

Conversation

@dworik
Copy link
Copy Markdown
Contributor

@dworik dworik commented May 12, 2026

Issue #2411

CI

  • test android emulator webview expected to fail
  • patrol_finders check semver expected to fail

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several platform-specific boolean getters to the PatrolTester class, including isAndroid, isIOS, and isWeb, to identify the current execution environment. The reviewer suggests refactoring the repeated platform check logic into a private helper method to improve maintainability and reduce code duplication.

Comment thread packages/patrol_finders/lib/src/custom_finders/patrol_tester.dart Outdated
Comment thread packages/patrol_finders/lib/src/custom_finders/patrol_tester.dart Outdated
Copy link
Copy Markdown
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rebase it on newest master and resolve conflict

Comment thread packages/patrol_finders/CHANGELOG.md Outdated
Copy link
Copy Markdown
Collaborator

@pdenert pdenert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dworik dworik merged commit 0dddfe5 into master May 15, 2026
17 of 20 checks passed
@dworik dworik deleted the feature/is-platform-getter branch May 15, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants