Add isPlatform getter for all platforms#3061
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several platform-specific boolean getters to the PatrolTester class, including isAndroid, isIOS, and isWeb, to identify the current execution environment. The reviewer suggests refactoring the repeated platform check logic into a private helper method to improve maintainability and reduce code duplication.
pdenert
reviewed
May 14, 2026
pdenert
reviewed
May 14, 2026
Collaborator
pdenert
left a comment
There was a problem hiding this comment.
Also rebase it on newest master and resolve conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2411
CI
test android emulator webviewexpected to failpatrol_finders check semverexpected to fail