Add support for multi-page web tests#3065
Open
Komoszek wants to merge 14 commits into
Open
Conversation
Add PageManager and 6 new Playwright actions (openNewTab, closeTab, switchToTab, getTabs, getCurrentTab, waitForPopup) enabling interaction with content in multiple browser tabs during web tests. Includes TypeScript unit and integration tests, Flutter E2E tests, documentation updates, and changelog entry.
github-actions
Bot
added
docs
🚀 Preview Deployment Ready!Preview URL: https://pr-3065-patrol-docs.vercel.app Latest Deployment
This preview URL is stable and will be updated with each new commit to this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces multi-tab browser support for web tests, adding methods like openNewPage, closePage, and switchToPage to the WebAutomator interface. The web runner is updated with a PageManager to handle multiple page instances, and comprehensive integration tests are included. Feedback highlights opportunities to reduce test flakiness by replacing fixed delays with explicit waits and suggests refactoring repetitive code in the native automator. Corrections were also provided for documentation syntax and type inconsistencies in contract tests.
Komoszek
requested review from
fylyppo,
mateuszwojtczak,
pdenert and
piotruela
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2968, enhances it with
getCurrentPageUrlandswitchToMainPagemethods