Rewrite compileLoad and compileStore#367
Closed
DutChen18 wants to merge 3 commits into
Closed
Conversation
DutChen18
force-pushed
the
rewrite-load-store
branch
from
d5f0aca to
986a1bf
Compare
Member
Author
|
Rebased on master |
yuri91
reviewed
May 1, 2026
Member
|
manually merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%1in%1 = load ptr, ptr %2to be different from the pointer kind of the value stored at%2. This never happens in the current PA because it forbids collapsing pointer kinds on load instructions, but the PA rewrite will allow this.getPointerKindForLoadStoreandgetConstantOffsetForLoadStore. For load instructions, these are identical togetPointerKindandgetConstantOffsetForPointer. For store instructions, these functions should operate on the value operand of the store instruction. Having a separate function for this simplifies the PA rewrite.