[Merged by Bors] - chore: adaptations for nightly-2026-04-16#209
Closed
kim-em wants to merge 106 commits into
Closed
[Merged by Bors] - chore: adaptations for nightly-2026-04-16#209kim-em wants to merge 106 commits into
kim-em wants to merge 106 commits into
Conversation
This provides a `PowIdentity K (Fintype.card K)` instance for any finite field, based on `FiniteField.pow_card` (Fermat's little theorem). This allows the `grind` ring solver to reduce high-degree polynomials over finite fields. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adapt to leanprover/lean4#13217 which requires indented tactic sequences after `by` and `decreasing_by`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adapt to leanprover/lean4#13217. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jcommelin
reviewed
Apr 17, 2026
| attribute [local simp] normalized hasNestedIf hasConstantIf hasRedundantIf disjoint vars | ||
| List.disjoint | ||
|
|
||
| set_option warning.simp.varHead false in |
Member
There was a problem hiding this comment.
Do we need to set up tech debt counters for these?
There was a problem hiding this comment.
That's a good point. I think this would be a good idea, as each such silencing means that there is an inefficient lemma in the simp set, but in the core lean4 there was an example, where this was done deliberately on a small local simpset.
…nity/mathlib4-nightly-testing into bump/nightly-2026-04-10
Author
|
bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Wojciech Rozowski <wojciech@lean-fro.org>
|
Pull request successfully merged into bump/v4.31.0. Build succeeded: |
mathlib-bors
Bot
changed the title
kim-em
added a commit
to leanprover-community/mathlib-ci
that referenced
this pull request
Apr 18, 2026
This PR adds a counter for `set_option warning.simp.varHead false` occurrences to the weekly tech debt report. The `warning.simp.varHead` option silences a warning introduced in Lean about simp lemmas whose LHS has a metavariable as its head. Places where this warning is silenced are tech debt we want to track over time. Prompted by discussion on leanprover-community/mathlib4-nightly-testing#209 which adds several `set_option warning.simp.varHead false in` uses. 🤖 Prepared with Claude Code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bryangingechen
pushed a commit
to leanprover-community/mathlib-ci
that referenced
this pull request
Apr 28, 2026
This PR adds a counter for `set_option warning.simp.varHead false` occurrences to the weekly tech debt report. The `warning.simp.varHead` option silences a warning introduced in Lean about simp lemmas whose LHS has a metavariable as its head. Places where this warning is silenced are tech debt we want to track over time. Prompted by discussion on leanprover-community/mathlib4-nightly-testing#209 which adds several `set_option warning.simp.varHead false in` uses. 🤖 Prepared with Claude Code Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kim-em
added a commit
to kim-em/mathlib-ci
that referenced
this pull request
May 22, 2026
…rover-community#21) This PR adds a counter for `set_option warning.simp.varHead false` occurrences to the weekly tech debt report. The `warning.simp.varHead` option silences a warning introduced in Lean about simp lemmas whose LHS has a metavariable as its head. Places where this warning is silenced are tech debt we want to track over time. Prompted by discussion on leanprover-community/mathlib4-nightly-testing#209 which adds several `set_option warning.simp.varHead false in` uses. 🤖 Prepared with Claude Code Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.