forked from leanprover-community/mathlib4
-
Notifications
You must be signed in to change notification settings - Fork 1
[Merged by Bors] - chore: adaptations for nightly-2026-05-11 #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
420 commits
Select commit
Hold shift + click to select a range
7dc9835
chore: add scoped `set_option backward.defeqAttrib.useBackward true`
nomeata 10cedd5
chore: file-level `set_option backward.defeqAttrib.useBackward true` …
nomeata 7740f44
fix(Tactic/DSimpPercent): elaborate `dsimp%` with `useBackward=true`
nomeata 9d376b1
Revert "fix(Tactic/DSimpPercent): elaborate `dsimp%` with `useBackwar…
nomeata 05c52ef
fix: scope useBackward=true around `extendRestrictScalarsAdj_counit_a…
nomeata 695ba36
fix: proof-level adaptations for 2 files under stricter defeq
nomeata 23e7296
fix: add `id_comp` to simp list in `CoGrothendieck.map.map_comp`
nomeata af17414
fix: spell out `ofIso`'s `s'_comp_ε` and `s₀_comp_δ₁` proofs
nomeata 0077a67
fix: adapt `colimitLimitToLimitColimit_injective`/`_surjective` proofs
nomeata 001bd00
chore: add `set_option backward.defeqAttrib.useBackward true` scoped …
nomeata ec24396
chore: add useBackward to failing decls (round 8)
nomeata d43f066
chore: add useBackward to failing decls (round 9, partial)
nomeata a1ce6af
fix: add useBackward to fix remaining failures in round 9
nomeata c4a60bd
chore: add useBackward to failing decls (round 10)
nomeata 10156b9
chore: add useBackward to failing decls (round 11)
nomeata 1962112
chore: add useBackward to failing decls (round 12)
nomeata 44a4ee2
chore: add useBackward to failing decls (round 13)
nomeata cd43604
chore: partial adds in round 14 (4 files still need manual fix)
nomeata 247c918
fix: scope useBackward at more decl sites (round 14 manual fixes)
nomeata caadb48
chore: useBackward on mapComp'_inv_naturality and pullHom_pullHom (do…
nomeata 7444acb
chore: partial attempts in IsPrestack (remains broken)
nomeata 5c760d3
chore: add useBackward to failing decls (round 15)
nomeata 4759a0d
fix: Stalk.lean needs useBackward on 4 decls
nomeata ddaf12b
chore: add useBackward to failing decls (round 16)
nomeata aa5123d
fix: add useBackward to mapComp'₀₂₃_inv_comp_mapComp'₀₁₃_hom and vari…
nomeata cd3a1c7
chore: round 17 partial (DescentData still broken)
nomeata ae74cc7
chore: partial useBackward on DescentData (still broken)
nomeata c15cdcf
chore: partial DescentData fixes (still has cascading issues)
nomeata fb8eeab
chore: file-level useBackward on DescentData, minor proof edits
nomeata f9b1ef7
chore: OpenImmersion.lean useBackward
nomeata 5a7002b
chore: partial DescentData - line 352 still has metavar issue
nomeata f740612
fix: DescentData + useBackward on mapComp'₀₂₃_hom
nomeata f376389
chore: round 18 partial
nomeata 6bd7f4a
fix: Precoverage.lean file-level useBackward
nomeata d08e84d
chore: round 20
nomeata b97f7ea
fix: `add_set_option.py` skip `variable`/`include`/`omit`/`open` lines
nomeata c57b5b0
chore: round 21 (GammaSpecAdjunction, Gluing)
nomeata 1f2094c
Revert "fix: `add_set_option.py` skip `variable`/`include`/`omit`/`op…
nomeata efdee48
chore: round 22
nomeata e777cce
chore: round 23
nomeata 4fd6972
chore: script-fixed 36 more mathlib modules with useBackward
nomeata 54e50ad
fix: add useBackward to 3 decls in Representability.lean
nomeata 45f3ee4
chore: remove unused simp arguments (326 across 123 files)
nomeata 4278b88
chore: fix long lines, `show` -> `change`, drop unused `- X` simp args
nomeata 8ca5b7e
chore: one more long-line fix
nomeata a6acd94
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13492
147150d
chore: useBackward on 3 MathlibTest files for lake test
nomeata 4decb39
Empty line
nomeata 9ad120a
Bump batteries
nomeata f3bf1a6
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13492
8085259
doc(scripts): document new helpers (fix_unused_simp_args.py, fix_long…
nomeata 418dd5c
chore: add `simpNF` nolints for 178 lemmas that simp can now prove
nomeata f2e6589
Merge master into nightly-testing
mathlib-nightly-testing[bot] 2d5b4c4
chore: bump to nightly-2026-04-23
mathlib-nightly-testing[bot] ec09924
cleanup
kim-em f0689d0
revert an unnecessary change
kim-em a6de9c2
revert unnecessary changes
kim-em c619ce1
add adaptation notes
kim-em 4ab7318
minor fixes, whitespace and PR links
kim-em 2eb2ebb
Merge master into nightly-testing
mathlib-nightly-testing[bot] f0b67bf
adaptation notes
kim-em a1669dc
two improvements
kim-em 46e62dc
fix
kim-em 062cd37
fix FilteredColimitCommutesFiniteLimit
dagurtomas adaef65
.
dagurtomas e18473c
fix IsPrestack
dagurtomas 5c1c60d
improvements
kim-em 3e2d7ce
Merge branch 'lean-pr-testing-13492' of https://github.com/leanprover…
kim-em ad19764
improvements
kim-em bd1ea33
fix extra degeneracy
dagurtomas 96954cc
Merge branch 'lean-pr-testing-13492' of github.com:leanprover-communi…
dagurtomas 16f6f39
small improvement in DerivedCategory/Ext
dagurtomas 6819973
slightly improve the proof in Limits/Shapes/Equalizers.lean
TwoFX 7d4b2eb
removed adaptation note for DerivedCategory/Ext/Map
joelriou 7f2aed1
More
TwoFX ea11aab
chore: bump to nightly-2026-04-24
mathlib-nightly-testing[bot] b5c35d6
adapt to lean4#13363: canUnfoldAtMatcher allowlist changes
nomeata 354733e
chore: remove unused helper lemmas from Ordinal/Notation adaptation
nomeata 6674d99
Merge branch 'nightly-testing-green' of https://github.com/leanprover…
nomeata 227f9b9
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13363
e4ce4fe
more cleaningup
joelriou 335001c
adapt Limits/Shapes/ConcreteCategory to lean4#13363
nomeata a76fdf7
Merge branch 'lean-pr-testing-13363' of https://github.com/leanprover…
nomeata ad1873b
Bump batteries
nomeata 21286e9
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13363
8f54182
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13492
706a5a9
Merge master into nightly-testing
mathlib-nightly-testing[bot] 18ebfae
chore: bump to nightly-2026-04-25
mathlib-nightly-testing[bot] 60da88c
merge lean-pr-testing-13363
mathlib-nightly-testing[bot] 358f262
Merge master into nightly-testing
mathlib-nightly-testing[bot] 13acb47
Update lean-toolchain for testing https://github.com/leanprover/lean4…
c22b6cc
satisfy linter
kim-em e8acaed
fixes
kmill a43b364
archive and counterexamples
kmill 5efa7dc
fix: round 30 - Pi/Basic + TensorProduct/Pi after nightly merge
nomeata f7196dc
chore: round 32 fixed by script
nomeata 39258cb
chore: round 33 (5 of 6 fixed by script)
nomeata 222989d
fix: Biproducts isoCoproduct simp leaves isTrue goal needing subst
nomeata 0b72dc6
chore: round 34 (3 of 5 by script)
nomeata cc40992
fix: round 34 SequentialProduct + StdSimplex
nomeata bcb51fa
chore: round 35
nomeata 7e99a9a
chore: round 36
nomeata ac59f87
chore: round 37
nomeata 5f939f8
chore: round 37 - remove unused simp args
nomeata 69cbc3c
chore: avoid 'adaptation note' substring in adaptation note bodies
nomeata f1fe074
Merge master into nightly-testing
mathlib-nightly-testing[bot] 23aa2cf
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13492
a663828
chore: round 41 (2 of 3 fixed by script)
nomeata fda4203
chore: resolve merge conflict in Sheaf/Free.lean
nomeata 33bcb54
chore: nolint two simpNF auto-generated lemmas
nomeata 1c9f879
Remove my custom scripts used for managing lean4#13492 migration
nomeata 9fc131c
chore: bump to nightly-2026-04-27
mathlib-nightly-testing[bot] 2cc71f2
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13528
e89a3fe
Merge master into nightly-testing
mathlib-nightly-testing[bot] f21126d
chore: bump to nightly-2026-04-28
mathlib-nightly-testing[bot] cc70049
merge lean-pr-testing-13359
mathlib-nightly-testing[bot] 5eeedb9
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13528
f977d54
Merge master into nightly-testing
mathlib-nightly-testing[bot] c76bb1d
Merge branch 'lean-pr-testing-13492' of https://github.com/leanprover…
kim-em 9a82400
chore: drop stale `DeprecatedModule` import in `RingTheory/Regular/De…
kim-em 36a46a3
chore: extend `lean-pr-testing-13492` set_option pattern to remaining…
kim-em 2ee6529
fix(AlgebraicTopology): repair `ε.naturality` under stricter defeq
kim-em 411c1e5
chore: extend `useBackward` set_option to two more pushout-product files
kim-em cbee8e1
chore: remove redundant `@[expose]` attributes flagged by lean4#13359
kim-em 4aadf4e
chore: add `@[expose] public section` to silence private-module warning
kim-em 7ecd070
chore: drop redundant `@[simp]` from `Pretriangulated.{id,comp}_hom₁/…
kim-em 1a0a9fa
chore: drop redundant `@[simp]` from `coe_id`/`coe_comp` in `Order.Ca…
kim-em 234a440
chore: drop redundant `@[simp]` flagged by simpNF in CategoryTheory +…
kim-em adc20b0
chore: drop more `@[simp]` flagged by simpNF as 'LHS simplifies from'
kim-em 223850f
chore: drop redundant `@[simp]` from `coe_id`/`coe_comp` in `Algebra.…
kim-em e18e7f9
chore: drop redundant `@[simps!]` on `WeierstrassCurve.{Affine,Jacobi…
kim-em 2ea642e
chore: drop redundant `@[simps!]`/`@[simp]` in CategoryTheory bicateg…
kim-em 9de5468
chore: trim more `@[simp]`/`@[simps]` flagged by simpNF
kim-em 33c181f
chore: trim more `@[simps]`/`@[simp]` flagged by simpNF (batch 4)
kim-em 356b280
chore: trim more `@[simps]`/`@[simp]` flagged by simpNF (batch 5, big)
kim-em 54c67e3
chore: bump to nightly-2026-04-29
mathlib-nightly-testing[bot] 20f3ba3
chore: fix namespace context in `attribute [-simp]` calls
kim-em 1eb2b45
chore: trim more simpNF-flagged simp lemmas (batch 6)
kim-em 8b29e60
chore: trim more simpNF-flagged simps via explicit projection lists
kim-em eb8f0c8
chore: drop redundant `@[simp]` from def equation lemmas
kim-em e73e4de
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13528
b421d1f
adaptation notes about nolint simpNF
kim-em a3dbe9e
chore: nolint simpNF on auto-generated equation lemmas
kim-em 4a44e99
chore: add adaptation_note to each `attribute [nolint simpNF]`
kim-em 7aa60c9
Merge master into nightly-testing
mathlib-nightly-testing[bot] 0202a3b
lake update batteries
kim-em e318d04
chore: fix mutual instance + filtered closure rfl failures
kim-em 074a3b8
chore: bump to nightly-2026-04-30
mathlib-nightly-testing[bot] bc95e57
Merge master into nightly-testing
mathlib-nightly-testing[bot] 8a5ba4c
chore: bump to nightly-2026-05-01
mathlib-nightly-testing[bot] e35ec4b
Merge master into nightly-testing
mathlib-nightly-testing[bot] 68bfddb
chore: bump to nightly-2026-05-02
mathlib-nightly-testing[bot] 36139e3
Merge branch 'lean-pr-testing-13528' of https://github.com/leanprover…
kim-em 15e2858
fix
kim-em 2d81cae
adaptation note
kim-em 1cf226f
fix bad merge
kim-em a19e131
adaptation notes
kim-em c76b942
fix
kim-em 6904ef7
fixes
kim-em eaa02ab
attributes
kim-em 36b1247
fixes
kim-em d919bc6
fixes via attributes
kim-em 9cbc30f
fixes
kim-em b8ec21d
linter
kim-em 76b8ecf
nolint
kim-em 8ff5d78
Update lean-toolchain for testing https://github.com/leanprover/lean4…
dec1ad9
chore: bump to nightly-2026-05-03
mathlib-nightly-testing[bot] 140aeda
remove unneeded simp
kim-em 09f2810
Merge branch 'nightly-testing' of github.com:leanprover-community/mat…
kim-em 71ad3f1
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13613
a58850c
Merge master into nightly-testing
mathlib-nightly-testing[bot] af7cd4b
chore: bump to nightly-2026-05-04
mathlib-nightly-testing[bot] fa3662a
chore: adaptations for nightly-2026-05-03
kim-em 516318b
fixes
kim-em a915409
Apply suggestions from code review
kim-em 9d88bb1
fixes from nightly-testing
kim-em b138e19
lake-manifest
kim-em 9b31753
Merge branch 'bump/v4.31.0' into bump/nightly-2026-05-03
kim-em 4151e8d
lake-manifest
kim-em 00b2942
merge bump/nightly-2026-05-03
kim-em 5b941f5
fix from nightly-testing
kim-em 47eaefe
Merge master into nightly-testing
mathlib-nightly-testing[bot] 274377a
merge upstream/master
kim-em 485ff94
Emerge
kim-em a4ed6a0
Merge remote-tracking branch 'upstream/master' into nightly-testing
a66913a
fix test
kim-em 9b5f2cd
chore: bump to nightly-2026-05-05
mathlib-nightly-testing[bot] d79879f
chore: restore @[to_additive (attr := simp)] symmetry
kim-em 09055b0
Revert "chore: restore @[to_additive (attr := simp)] symmetry"
kim-em 3be4aac
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13613
eb6f701
fix(to_additive): propagate @[defeq] symmetrically to additive transl…
kim-em 9405f76
chore: restore @[to_additive (attr := simp)] symmetry
kim-em afa506e
Merge master into nightly-testing
mathlib-nightly-testing[bot] c7c433c
chore: drop redundant @[simps!] on Mon.mkIso / AddMon.mkIso
kim-em 05124db
deprecation
kim-em 084301b
fix
kim-em e27262b
deprecation
kim-em f238619
Merge remote-tracking branch 'nightly-testing/bump/nightly-2026-05-03…
kim-em cc77eee
chore: restore lost content from #38972 merge in Cartesian/Mon.lean
kim-em 9a7efec
add missing imports (as public)
Kha c68d62a
chore: bump to nightly-2026-05-06
mathlib-nightly-testing[bot] b85b550
Update lean-toolchain for https://github.com/leanprover/lean4/pull/13613
bd907b4
Merge master into nightly-testing
mathlib-nightly-testing[bot] 5176738
chore: bump to nightly-2026-05-07
mathlib-nightly-testing[bot] 010b127
merge lean-pr-testing-13613
mathlib-nightly-testing[bot] c6c7e52
fix
kim-em 2dc7f3c
remove `change` tactics flagged by unusedTactics linter
kim-em 8f893cb
fix
kim-em 6203e81
fix
kim-em fa05551
fix
kim-em 81e9b52
fix
kim-em c34f13b
Merge master into nightly-testing
mathlib-nightly-testing[bot] 954f789
fix
kim-em 03370a8
Merge branch 'nightly-testing' of github.com:leanprover-community/mat…
kim-em abace82
fixes
kim-em cb919af
fixes
kim-em 17bde92
fixes
kim-em ae87437
fixes
kim-em 9295f09
adaptation note
kim-em f6071c1
linting
kim-em 0ac33d3
Merge master into nightly-testing
mathlib-nightly-testing[bot] 4899732
chore: adaptations for nightly-2026-05-07
kim-em aacaaef
Apply suggestions from code review
kim-em ddb2214
chore: bump to nightly-2026-05-09
mathlib-nightly-testing[bot] 90cc582
Merge master into nightly-testing
mathlib-nightly-testing[bot] dac2e97
chore: revert spurious blank-line additions
kim-em 3819811
chore: revert remaining spurious blank-line additions
kim-em fc1dbdf
chore: undo over-eager blank-line reverts (restore lines from PR base)
kim-em 5b5cb2f
chore: bump to nightly-2026-05-10
mathlib-nightly-testing[bot] 60053bf
chore(Cache/IO): drop `open private` for now-public `Lake.Glob.ofStri…
kim-em 794ec9a
chore(Data/String/Lemmas): add `length_toList` to `simp` set in leftp…
kim-em 34acbe6
chore(RingTheory/Bialgebra/TensorProduct): enable `backward.defeqAttr…
kim-em bb8b93e
Apply suggestions from code review
kim-em c11913a
fix: restore mapFreeIso_hom lemma from #38341
kim-em b099d52
Merge branch 'bump/nightly-2026-05-07' into nightly-testing
kim-em 3513e6d
Merge master into nightly-testing
mathlib-nightly-testing[bot] 688045e
fix: drop stale Reorder defs re-added during merge
kim-em 21f1484
fixes
kim-em e22c93c
fixes
kim-em 1d44d76
fix
kim-em 860fc28
fix
kim-em 90ed4b0
chore: adaptations for nightly-2026-05-10
kim-em eb152ad
Merge remote-tracking branch 'nightly-testing/bump/nightly-2026-05-10…
kim-em 79d7f18
chore: bump to nightly-2026-05-11
mathlib-nightly-testing[bot] 3b7d27c
chore: adaptations for nightly-2026-05-11
kim-em 01e631c
fixes
kim-em ff96912
fix
kim-em 9ad23d1
fix
kim-em 8d23240
Merge branch 'bump/v4.31.0' into bump/nightly-2026-05-11
kim-em 731a30f
chore(nightly-testing): fix build after lean updates
kim-em File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| leanprover/lean4:nightly-2026-05-10 | ||
| leanprover/lean4:nightly-2026-05-11 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, we get a warning saying it was already not exposed.