feat(AlgebraicTopology/SimplicialSet): exists_isPushout_of_ne_top#38848
feat(AlgebraicTopology/SimplicialSet): exists_isPushout_of_ne_top#38848jcreinhold wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
505a483 to
c8d7ba9
Compare
PR summary c7129933eeImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.AlgebraicTopology.SimplicialSet.Boundary | 914 | 956 | +42 (+4.60%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.AlgebraicTopology.SimplicialSet.AnodyneExtensions.Basic |
1 |
Mathlib.AlgebraicTopology.SimplicialSet.Skeleton |
14 |
Mathlib.AlgebraicTopology.Quasicategory.StrictBicategory |
15 |
Mathlib.AlgebraicTopology.SimplicialSet.KanComplex.MulStruct |
19 |
5 filesMathlib.AlgebraicTopology.Quasicategory.Basic Mathlib.AlgebraicTopology.Quasicategory.Nerve Mathlib.AlgebraicTopology.Quasicategory.StrictSegal Mathlib.AlgebraicTopology.SimplicialSet.CategoryWithFibrations Mathlib.AlgebraicTopology.SimplicialSet.KanComplex |
31 |
Mathlib.AlgebraicTopology.SimplicialSet.Boundary |
42 |
Declarations diff
+ exists_isPushout_of_ne_top
+ isPullback_of_eq_setPreimage
+ preimage_yonedaEquivSymm_eq_boundary
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Increase in tech debt: (relative, absolute) = (2.00, 0.00)
| Current number | Change | Type |
|---|---|---|
| 5844 | 2 | backward.isDefEq.respectTransparency |
Current commit 4d4767932f
Reference commit c7129933ee
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
c8d7ba9 to
505a483
Compare
505a483 to
b4a86be
Compare
|
Thanks for the PR! Was any of this generated by a LLM? If so, you might consider adding the |
Cut the PR down to just the adaptation of @joelriou 's proof. None of this code is LLM generated, albeit I used an LLM to look through mathlib4 for existing relevant structures finding I made a few contributions last year, so I didn't re-read the contribution guide and see the (new?) section on AI/LLM use. Happy to close this if I broke the intended conduct guidelines. Not my intent to waste any maintainer's time. |
|
On the Four options I see:
Perhaps there's another way I'm not seeing? |
Every proper subcomplex of a simplicial set extends by attaching a single cell along its boundary, exhibited as a pushout of
∂Δ[n] ↪ Δ[n]. This is the per-cell input for cell-by-cell filtrations of monomorphisms inSSet.Adapted from @joelriou 's proof. I also added the supporting lemma
Types.isPullback_of_eq_setPreimage(set-preimage square is a pullback inType u).AI use: Claude helped locate
subtype_val_monoand thebackward.isDefEq.respectTransparencyoption.