Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
a3b79b7
feat: custom elaborators for differential geometry
grunweg Jul 12, 2025
81c019b
Remove unused deprecated elaborators; noshake
grunweg Jul 12, 2025
6b09d20
Scope delaborators
grunweg Jul 12, 2025
7be9e94
More minimal imports
grunweg Jul 12, 2025
aeacd20
Use double backticks
grunweg Jul 12, 2025
79c9622
Manual noshake
grunweg Jul 12, 2025
0fa641c
chore(Elaborators): fix a few typos in doc-strings
grunweg Jul 17, 2025
2e80df4
feat: custom elaborator for mderiv(Within)
grunweg Jul 17, 2025
e77fbc4
And add some tests, including some for (already fine) error messages
grunweg Jul 17, 2025
ccb3926
Fix the build
grunweg Jul 17, 2025
bae571b
A few fixes from review
grunweg Aug 6, 2025
3e0d75f
fix: precendence in T%.
grunweg Aug 6, 2025
273f4cd
chore: note one TODO
grunweg Aug 6, 2025
1c6fcac
chore: review comments
grunweg Aug 26, 2025
1738036
wip: test for beta-reduction in T %
grunweg Aug 26, 2025
d61ded3
wip: beta-reduce in T% elaborator
grunweg Aug 26, 2025
500c20d
Revert "wip: beta-reduce in T% elaborator"
grunweg Aug 26, 2025
4b82f39
Two more typos
grunweg Sep 30, 2025
fb21400
Document trace classes
grunweg Sep 30, 2025
24ce05b
Document product case better
grunweg Sep 30, 2025
0ab1b3b
Clarify cryptic TODO
grunweg Sep 30, 2025
9c3f38a
chore: structure the tests better
grunweg Sep 30, 2025
5785f53
chore: add many tests for the CMDiffAt elaborators
grunweg Sep 30, 2025
4a9a454
chore: add tests about coercion behaviour
grunweg Sep 30, 2025
aa520d0
Support coercion n to WithTop ENat everywhere.
grunweg Sep 30, 2025
a5ff9ea
fix: guard against loose bvars, i.e. non-dependent functions
grunweg Sep 30, 2025
1923717
Add tests for mfderiv and dependent fns also
grunweg Sep 30, 2025
44f57de
wip/refactor: use forallBoundedTelescope instead of manual matching
grunweg Sep 30, 2025
734cb55
Note another TODO
grunweg Sep 30, 2025
44ecf37
And another
grunweg Sep 30, 2025
c08dc09
Update error messages for merge
grunweg Sep 30, 2025
86e3b1a
One more check and test
grunweg Sep 30, 2025
6277145
chore: use Hint: instead of Note:
grunweg Sep 30, 2025
74432d5
Apply suggestions from code review
grunweg Sep 30, 2025
c68ce87
Update MathlibTest/DifferentialGeometry/Elaborators.lean
grunweg Sep 30, 2025
4512cf6
Stronger warning
grunweg Sep 30, 2025
9b41163
Use Hint more
grunweg Sep 30, 2025
05c4860
Document and polish find_models better
grunweg Sep 30, 2025
48d7998
refactor: reduce duplication in the various small elaborators
grunweg Sep 30, 2025
a728621
chore: validate the types of s and src match
grunweg Sep 30, 2025
04c188a
fix(Elaborators): pretty-print the new elaborated notation correctly
grunweg Sep 30, 2025
52e0ee0
chore: move mkApp12 to a Lean
grunweg Oct 3, 2025
74cfff3
chore: move getUniverse to Lean/Meta/ElabTerm
grunweg Oct 3, 2025
3abe5ed
Fix
grunweg Oct 3, 2025
b3bf609
Fix test; tweak error message
grunweg Oct 3, 2025
e693a60
Merge branch 'master' into diffgeo-custom-elaborators
grunweg Oct 4, 2025
c08a5c0
(Git wrangling) Revert "Fix test; tweak error message"
thorimur Oct 4, 2025
5c44849
(Git wrangling) Revert "Fix"
thorimur Oct 4, 2025
66c7cdb
(Git wrangling) Revert "chore: move getUniverse to Lean/Meta/ElabTerm"
thorimur Oct 4, 2025
aa083bd
(Git wrangling) Revert "chore: move mkApp12 to a Lean"
thorimur Oct 4, 2025
e0bea74
style: remove `>>=`
thorimur Oct 1, 2025
45b0619
chore: reduce `etype` to get `.forallE`
thorimur Oct 4, 2025
76765aa
chore: `whnfR` after `instantiateMVars`
thorimur Oct 1, 2025
753bf77
chore: remove `getUniverse` in favor of `mkAppOptM`
thorimur Oct 1, 2025
54d24fa
chore: `PrettyPrinter.delab` -> `Term.exprToSyntax`
thorimur Oct 2, 2025
39195b9
chore(Elaborators): change trace class names
thorimur Oct 2, 2025
5513488
feat: move trace classes into main file; make collective trace class;…
thorimur Oct 2, 2025
bd08a3d
chore: rename `find_model` -> `findModel`, `_find_models` -> `findMod…
thorimur Oct 2, 2025
61b350b
chore: use Qq to construct `WithTop ℕ∞`
thorimur Oct 2, 2025
a0587df
refactor: factor out loops into (private) definitions for readability…
thorimur Oct 2, 2025
38b2737
chore: remove unnecessary `m!`s
thorimur Oct 2, 2025
73c361f
style: use `withLocalDeclD`
thorimur Oct 2, 2025
c5c51c5
chore: append `Elab` namespace
thorimur Oct 2, 2025
3b34391
style: fix `findModel` body indentation
thorimur Oct 2, 2025
f4a788d
chore: grammar
thorimur Oct 2, 2025
d2be1b9
style: code fencing instead of quotes in messages
thorimur Oct 2, 2025
98d4eaf
chore: typo
thorimur Oct 2, 2025
8c30410
fix: don't use `BEq` to compare expressions
thorimur Oct 2, 2025
0f85d74
fix: do not use `arg` precedence in brackets
thorimur Oct 2, 2025
d61a7ed
fix: reset `TermElabM` state in `findModel` appropriately when trying…
thorimur Oct 3, 2025
9148311
chore: use `match_expr` in `findModel`
thorimur Oct 3, 2025
542daa2
chore: use `match_expr` in `T%`
thorimur Oct 3, 2025
7208266
chore: remove `mkApp12`
thorimur Oct 3, 2025
95c9baf
style: use dot notation for `hasLooseBVars`
thorimur Oct 3, 2025
eca902d
chore: move `findSomeLocalInstanceOf?` above `T%`
thorimur Oct 3, 2025
1ed3ba2
chore: comment for `findSomeLocalInstanceOf?`
thorimur Oct 4, 2025
e6af20c
chore: use `findSomeLocalInstanceOf?` in `T%`, and explain why we don…
thorimur Oct 3, 2025
915bb32
chore: perform cheapest check first
thorimur Oct 3, 2025
a96e441
chore: use `pureIsDefEq` or explain why not
thorimur Oct 3, 2025
77f1023
chore: comment out (fixed) `MDiffAt2` and remove test
thorimur Oct 2, 2025
32bfff5
chore: use commented-out code instead of syntax re-elab
thorimur Oct 3, 2025
8fc91f3
chore: TODO comments
thorimur Oct 3, 2025
d2be66b
fix: make elaborators `scoped`, as promised
thorimur Oct 3, 2025
9d4bcbe
docs: clean up module docstring
thorimur Oct 4, 2025
3866f8a
docs: misc. style, typos, wording
thorimur Oct 4, 2025
3edd779
style(`T%`): `e.app`
thorimur Oct 4, 2025
11b39ab
style: line reflow
thorimur Oct 4, 2025
81cd4e0
fix: scope `T%` to `Manifold`
thorimur Oct 4, 2025
6bbacad
chore: refactor `findModels` to clean up elabs
thorimur Oct 3, 2025
95f24ae
style: indent second line of multiline errors
thorimur Oct 5, 2025
d56601d
chore: improve error message for trivial bundle
thorimur Oct 5, 2025
1976265
test: tracing
thorimur Oct 6, 2025
0fa0ca7
chore: affirm that this check is fine!
thorimur Oct 6, 2025
c51a943
Merge pull request #1 from thorimur/diffgeo-custom-elaborators-review
grunweg Oct 6, 2025
d68de78
chore: move file to Notation.lean
grunweg Oct 6, 2025
6ca727d
Review comments
grunweg Oct 6, 2025
7bc54f0
chore: add missing test; fails for reasons I don't understand
grunweg Oct 6, 2025
bf9b5e4
Update Mathlib/Geometry/Manifold/Notation.lean
grunweg Oct 6, 2025
e6bd1b9
Add docs for auxiliary doc-strings
grunweg Oct 6, 2025
5838675
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Oct 6, 2025
14cc4ed
Update Mathlib/Geometry/Manifold/Notation.lean
grunweg Oct 7, 2025
77a71aa
Update expected output
grunweg Oct 6, 2025
7411ecd
Comment the recent test
grunweg Oct 7, 2025
6217313
chore: move test
grunweg Oct 7, 2025
41046cd
chore: add regression test for precendence in the "on/within" set
grunweg Oct 7, 2025
faf1b24
Clarify failing test, and document the right spelling with TangentBundle
grunweg Oct 7, 2025
8e5d337
Noshake; fix bad merge/import
grunweg Oct 8, 2025
fb2e2b6
Update Mathlib/Geometry/Manifold/Notation.lean
grunweg Oct 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Mathlib.lean
Original file line number Diff line number Diff line change
Expand Up @@ -3928,6 +3928,7 @@ import Mathlib.Geometry.Manifold.MFDeriv.SpecificFunctions
import Mathlib.Geometry.Manifold.MFDeriv.Tangent
import Mathlib.Geometry.Manifold.MFDeriv.UniqueDifferential
import Mathlib.Geometry.Manifold.Metrizable
import Mathlib.Geometry.Manifold.Notation
import Mathlib.Geometry.Manifold.PartitionOfUnity
import Mathlib.Geometry.Manifold.PoincareConjecture
import Mathlib.Geometry.Manifold.Riemannian.Basic
Expand Down
Loading