[Merged by Bors] - feat(Algebra/IsScalarTower): add transitivity results #27866
[Merged by Bors] - feat(Algebra/IsScalarTower): add transitivity results #27866xroblot wants to merge 7 commits into
Conversation
PR summary a7cf25eee0Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
There was a problem hiding this comment.
I have more general versions here (link updated). It's interesting to note the asymmetry between the required conditions for the two versions.
|
@xroblot @alreadydone Are you okay with having both commits in this PR? Then I'll do a final review and get this merged. |
|
Do you mean you want to merge my commit into this PR? I can open a pull request. |
|
Yes! That way we won't add something and then replace it immediately after. Your commit looks good to me, so I'd only like to make sure that the merge is good, and we can merge this PR. |
|
I opened xroblot#1. Probably the docstrings need to be rewritten and added. I'm not sure about the |
|
I am happy with whatever solution you think it's the best. |
…nto isscalartower_trans
|
Thanks! Let's get this merged, finally :) bors r+ |
|
👎 Rejected by label |
|
@Vierkantor I think this PR needs another push |
|
Oops, let's try that again! bors r+ |
Add the following: ``` Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are scalar towers, then `Q / N / M` is also a scalar tower. ``` and variations. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
…munity#27866) Add the following: ``` Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are scalar towers, then `Q / N / M` is also a scalar tower. ``` and variations. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
…munity#27866) Add the following: ``` Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are scalar towers, then `Q / N / M` is also a scalar tower. ``` and variations. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
…munity#27866) Add the following: ``` Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are scalar towers, then `Q / N / M` is also a scalar tower. ``` and variations. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Add the following:
and variations.
Co-authored-by: Junyan Xu junyanxu.math@gmail.com