Skip to content

[Merged by Bors] - feat(Algebra/IsScalarTower): add transitivity results #27866

Closed
xroblot wants to merge 7 commits into
leanprover-community:masterfrom
xroblot:isscalartower_trans
Closed

[Merged by Bors] - feat(Algebra/IsScalarTower): add transitivity results #27866
xroblot wants to merge 7 commits into
leanprover-community:masterfrom
xroblot:isscalartower_trans

Conversation

@xroblot

@xroblot xroblot commented Aug 2, 2025

Copy link
Copy Markdown
Collaborator

Add the following:

Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are
scalar towers, then `Q / N / M` is also a scalar tower.

and variations.

Co-authored-by: Junyan Xu junyanxu.math@gmail.com


Open in Gitpod

@xroblot xroblot added the WIP Work in progress label Aug 2, 2025
@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Aug 2, 2025
@github-actions

github-actions Bot commented Aug 2, 2025

Copy link
Copy Markdown

PR summary a7cf25eee0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsScalarTower.to₁₂₃
+ IsScalarTower.to₁₂₄
+ IsScalarTower.to₁₃₄
+ IsScalarTower.to₂₃₄

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 11, 2025

@alreadydone alreadydone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more general versions here (link updated). It's interesting to note the asymmetry between the required conditions for the two versions.

@Vierkantor

Copy link
Copy Markdown
Contributor

@xroblot @alreadydone Are you okay with having both commits in this PR? Then I'll do a final review and get this merged.

@alreadydone

Copy link
Copy Markdown
Contributor

Do you mean you want to merge my commit into this PR? I can open a pull request.

@Vierkantor

Copy link
Copy Markdown
Contributor

Yes! That way we won't add something and then replace it immediately after. Your commit looks good to me, so I'd only like to make sure that the merge is good, and we can merge this PR.

@alreadydone

Copy link
Copy Markdown
Contributor

I opened xroblot#1. Probably the docstrings need to be rewritten and added. I'm not sure about the trans in the names; I think to_left/to_right would be better.

@xroblot

xroblot commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator Author

I am happy with whatever solution you think it's the best.

@xroblot xroblot added the WIP Work in progress label Aug 19, 2025
@Vierkantor

Copy link
Copy Markdown
Contributor

Thanks! Let's get this merged, finally :)

bors r+

@mathlib-bors

mathlib-bors Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

👎 Rejected by label

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Aug 19, 2025
@alreadydone alreadydone removed the WIP Work in progress label Aug 19, 2025
@xroblot

xroblot commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator Author

@Vierkantor I think this PR needs another push

@Vierkantor

Copy link
Copy Markdown
Contributor

Oops, let's try that again!

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Aug 19, 2025
Add the following: 
```
Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are
scalar towers, then `Q / N / M` is also a scalar tower.
```
and variations.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors

mathlib-bors Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Algebra/IsScalarTower): add transitivity results [Merged by Bors] - feat(Algebra/IsScalarTower): add transitivity results Aug 19, 2025
@mathlib-bors mathlib-bors Bot closed this Aug 19, 2025
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Aug 20, 2025
…munity#27866)

Add the following: 
```
Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are
scalar towers, then `Q / N / M` is also a scalar tower.
```
and variations.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…munity#27866)

Add the following: 
```
Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are
scalar towers, then `Q / N / M` is also a scalar tower.
```
and variations.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…munity#27866)

Add the following: 
```
Let `Q / P / N / M` be a scalar tower. If `P / N / M`, `Q / P / M` and `Q / P / N` are
scalar towers, then `Q / N / M` is also a scalar tower.
```
and variations.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@xroblot xroblot deleted the isscalartower_trans branch March 16, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants