Skip to content

chore: remove extraneous uses of push_neg#31596

Closed
grunweg wants to merge 14 commits intoleanprover-community:masterfrom
grunweg:contrapose-harder
Closed

chore: remove extraneous uses of push_neg#31596
grunweg wants to merge 14 commits intoleanprover-community:masterfrom
grunweg:contrapose-harder

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Nov 13, 2025


Ideally, repeat this experiment after the new contrapose! for equivalences has been merged...

Open in Gitpod

@grunweg grunweg added the WIP Work in progress label Nov 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 13, 2025

PR summary b02af05520

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Config
+ LogIfUnchanged

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.33)
Current number Change Type
3 1 maxHeartBeats modifications

Current commit 511065bf3e
Reference commit b02af05520

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 17, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 11, 2026

Closing in favour of #37937.

@grunweg grunweg closed this Apr 11, 2026
@grunweg grunweg deleted the contrapose-harder branch April 11, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants