[Merged by Bors] - chore: replace by_contra! and contrapose! with plain versions#31600
Closed
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: replace by_contra! and contrapose! with plain versions#31600grunweg wants to merge 4 commits intoleanprover-community:masterfrom
grunweg wants to merge 4 commits intoleanprover-community:masterfrom
Conversation
…thing Not exhaustive yet.
PR summary 21f7dcba68Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
grunweg
commented
Dec 23, 2025
| contrapose! ha | ||
| simp [ha] | ||
| contrapose ha | ||
| simp [not_nonempty_iff_eq_empty.1 ha] |
Contributor
Author
There was a problem hiding this comment.
I'm happy to revert this one if preferred
Contributor
There was a problem hiding this comment.
It's not entirely clear to me which option is better, but I think I'd prefer the original
Contributor
|
Thanks 🎉 maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by JovanGerb. |
ghost
added
the
maintainer-merge
grunweg
commented
Dec 23, 2025
Contributor
|
Should the title of the PR mention |
grunweg
changed the title
adomani
reviewed
Dec 24, 2025
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Contributor
Author
|
Thanks for the reviews! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 24, 2025
When the push_neg step in these tactics does nothing, write just `by_contra` resp. `contrapose`. Not exhaustive.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
…over-community#31600) When the push_neg step in these tactics does nothing, write just `by_contra` resp. `contrapose`. Not exhaustive.
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
…over-community#31600) When the push_neg step in these tactics does nothing, write just `by_contra` resp. `contrapose`. Not exhaustive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the push_neg step in these tactics does nothing, write just
by_contraresp.contrapose.Not exhaustive.
Spun out of #31596.