-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Merged by Bors] - feat(RingTheory/ClassGroup): prove mulEquiv #35535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d33499d
feat(RingTheory/ClassGroup): prove mulEquiv
mariainesdff 6a6138c
some suggested changes
mariainesdff 3b717ee
suggested change
mariainesdff cbb0ffe
fix build
mariainesdff 1620702
lint
mariainesdff 5226493
Merge branch 'master' into class_group_equiv
mariainesdff 3033593
suggested changes
mariainesdff 656ca84
remove instance
mariainesdff 689b7e1
fix
mariainesdff 7f33d1b
Merge branch 'master' into class_group_equiv
mariainesdff 8fdb591
fix
mariainesdff dc8a439
fix
mariainesdff 13afa3a
suggested change
mariainesdff 101f5dc
Merge branch 'master' into class_group_equiv
mariainesdff a66f1d6
Merge branch 'master' into class_group_equiv
mariainesdff 2d0b331
test change
mariainesdff 7d620cc
suggested changes
mariainesdff 0854ea2
suggested change
mariainesdff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -414,3 +414,43 @@ theorem card_classGroup_eq_one_iff [IsDedekindDomain R] [Fintype (ClassGroup R)] | |
| by_cases hI : I = ⊥ | ||
| · rw [hI]; exact bot_isPrincipal | ||
| · exact (ClassGroup.mk0_eq_one_iff (mem_nonZeroDivisors_iff_ne_zero.mpr hI)).mp (eq_one _) | ||
|
|
||
| section MulEquiv | ||
|
|
||
| theorem FractionalIdeal.map_ringEquivOfRingEquiv_toPrincipalIdeal {S L : Type*} [CommRing S] | ||
| [IsDomain S] [Field L] [Algebra S L] [IsFractionRing S L] (f : R ≃+* S) : | ||
| Subgroup.map ((Units.mapEquiv (ringEquivOfRingEquiv K L f))).toMonoidHom | ||
| (toPrincipalIdeal R K).range = (toPrincipalIdeal S L).range := by | ||
| ext I | ||
| simp only [MulEquiv.toMonoidHom_eq_coe, Subgroup.mem_map, MonoidHom.mem_range, | ||
| toPrincipalIdeal_eq_iff, MonoidHom.coe_coe] | ||
| refine ⟨fun ⟨u, ⟨v, huv⟩, hu⟩ ↦ ?_, fun ⟨u, hu⟩ ↦ ?_⟩ | ||
| · use Units.map (IsFractionRing.ringEquivOfRingEquiv f (K := K) | ||
| (L := L)).toRingHom v | ||
| rw [← hu] | ||
| simp only [RingEquiv.toRingHom_eq_coe, Units.coe_map, MonoidHom.coe_coe, RingHom.coe_coe, | ||
| Units.coe_mapEquiv, ← huv, RingEquiv.coe_toMulEquiv] | ||
| rw [FractionalIdeal.ringEquivOfRingEquiv_spanSingleton] | ||
| · use Units.mapEquiv (FractionalIdeal.ringEquivOfRingEquiv _ _ f).symm.toMulEquiv I | ||
| refine ⟨?_, by simp [← Units.val_inj]⟩ | ||
| · use Units.map (IsFractionRing.ringEquivOfRingEquiv f (K := K) | ||
| (L := L)).symm.toRingHom u | ||
| simp only [IsFractionRing.ringEquivOfRingEquiv_symm, RingEquiv.toRingHom_eq_coe, | ||
| Units.coe_map, MonoidHom.coe_coe, RingHom.coe_coe, RingEquiv.toMulEquiv_eq_coe, | ||
| RingEquiv.coe_toMulEquiv_symm, Units.coe_mapEquiv] | ||
| rw [← FractionalIdeal.ringEquivOfRingEquiv_spanSingleton, | ||
| ← FractionalIdeal.ringEquivOfRingEquiv_symm_eq, hu] | ||
| rfl | ||
|
|
||
| /-- A ring isomorphism `P ≃+* P'` induces an isomorphism on their class groups. -/ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you characterize via a lemma what this isomorphism does to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think there is a nice formula for this. |
||
| @[simps!] | ||
| noncomputable def ClassGroup.mulEquiv {P P' : Type*} [CommRing P] [IsDomain P] [CommRing P'] | ||
|
mariainesdff marked this conversation as resolved.
Outdated
|
||
| [IsDomain P'] (g : P ≃+* P') : ClassGroup P ≃* ClassGroup P' := | ||
| (ClassGroup.equiv (R := P) (FractionRing P)).trans | ||
| ((QuotientGroup.congr (toPrincipalIdeal P (FractionRing P)).range | ||
| (toPrincipalIdeal P' (FractionRing P')).range | ||
| (Units.mapEquiv (FractionalIdeal.ringEquivOfRingEquiv (FractionRing P) (FractionRing P') g)) | ||
| (FractionalIdeal.map_ringEquivOfRingEquiv_toPrincipalIdeal g)).trans | ||
| (ClassGroup.equiv (FractionRing P')).symm) | ||
|
|
||
| end MulEquiv | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.