[Merged by Bors] - feat(Analysis/InnerProductSpace): Gram matrix det ≠ 0 iff input vectors are independent#37918
Closed
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - feat(Analysis/InnerProductSpace): Gram matrix det ≠ 0 iff input vectors are independent#37918wwylele wants to merge 2 commits intoleanprover-community:masterfrom
wwylele wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
…ors are independent
Open
1 task
PR summary ade87df682Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.InnerProductSpace.GramMatrix | 2145 | 2454 | +309 (+14.41%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.InnerProductSpace.GramMatrix |
309 |
Declarations diff
+ PosSemidef.posDef_iff_det_ne_zero
+ det_gram_ne_zero_iff_linearIndependent
+ linearIndependent_of_det_gram_ne_zero
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
I'm okay with the import increase since this is a leaf (or at least it has no downstream import increases). bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small lemma extracted from #37295. Convenient for talking about the determinant directly without detour through Pos(Semi)def