Skip to content

chore: cleanup of adaptation notes#37922

Open
kim-em wants to merge 2 commits intomasterfrom
cleanup_adaptation_notes
Open

chore: cleanup of adaptation notes#37922
kim-em wants to merge 2 commits intomasterfrom
cleanup_adaptation_notes

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Apr 11, 2026


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2026

PR summary 9036ce5439

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (6.02, 1.29)
Current number Change Type
133 -35 adaptation notes
5 -5 maxHeartBeats modifications
147 -4 simp +instances

Current commit cb009dbf7e
Reference commit 9036ce5439

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just two small questions.
bors d+

Comment thread Mathlib/RingTheory/Valuation/Discrete/Basic.lean
rw [if_neg]
· exact terminalIsTerminal
· #adaptation_note /-- 2024-03-24
Previously the universe annotation was not needed here. -/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say a word about this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this one for now.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 11, 2026

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Apr 11, 2026
@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 11, 2026

noncomputable section

#adaptation_note
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just move the noncomputable section a bit upwards to fix this.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 13, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@kim-em kim-em force-pushed the cleanup_adaptation_notes branch from 728c05e to cb009db Compare April 17, 2026 22:49
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants