Skip to content

perf(Tactic/FastInstance): use whnf on data fields #37924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JovanGerb wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −3
Open

perf(Tactic/FastInstance): use whnf on data fields #37924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee2ce22
perf(Tactic/FastInstance): use `whnf` on data fields
JovanGerb Apr 11, 2026
e283a60
fix test
JovanGerb Apr 11, 2026
b6ad48a
don't change the transparency
JovanGerb Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Mathlib/Tactic/FastInstance.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ partial def makeFastInstance (inst expectedType : Expr) (trace : Array Name := #
mvarId.assign (← makeFastInstance arg argExpectedType (trace := trace'))
else
-- For data fields, make sure that the lambda binders have the right type.
forallTelescopeReducing argExpectedType fun xs _ ↦ do
mvarId.assign <| ← mkLambdaFVars xs (arg.beta xs)
mvarId.assign <| ← forallTelescopeReducing argExpectedType fun xs _ ↦ do
mkLambdaFVars xs (← whnfI (mkAppN arg xs))
return mkAppN f (← mvars.mapM instantiateMVars)

/--
Expand Down
2 changes: 1 addition & 1 deletion MathlibTest/InferInstanceAsPercent.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ instance myNatInv_fixed : MyInv MyNat :=
-- The binder type is `MyNat`:
/--
info: @[implicit_reducible] def myNatInv_fixed : MyInv MyNat :=
{ myInv := fun (a : MyNat) => a + 1 }
{ myInv := fun (a : MyNat) => (Nat.add a 0).succ }
-/
#guard_msgs in
#print myNatInv_fixed
Expand Down
Loading