Skip to content

refactor(Computability.Encoding): unbundle Γ and remove FinEncoding#37928

Open
AlexeyMilovanov wants to merge 4 commits intoleanprover-community:masterfrom
AlexeyMilovanov:refactor-encoding-unbundle
Open

refactor(Computability.Encoding): unbundle Γ and remove FinEncoding#37928
AlexeyMilovanov wants to merge 4 commits intoleanprover-community:masterfrom
AlexeyMilovanov:refactor-encoding-unbundle

Conversation

@AlexeyMilovanov
Copy link
Copy Markdown
Contributor

This PR unbundles the alphabet Γ from the Encoding structure and completely removes FinEncoding.

Encoding: The alphabet Γ is now an explicit parameter: structure Encoding (α : Type u) (Γ : Type v).
FinEncoding: Removed. Finiteness is now handled via standard typeclasses (e.g., [Fintype Γ] (e : Encoding α Γ)).
Combinators: Functions like finEncodingPair are simplified to encodingPair, dropping the fin prefix and [Fintype] requirements where no longer needed.
Downstream: Mechanically updated Mathlib.Computability and Mathlib.ModelTheory to pass the explicit Γ and use [Fintype Γ] where FinEncoding was previously required.

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 11, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2026

PR summary 35e1c7ee9f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ encodingBoolBool
+ encodingList
+ encodingPair
+ unaryEncodingNat
+--+ encoding
- FinEncoding
- FinEncoding.card_le_aleph0
- finEncodingBoolBool
- finEncodingList
- finEncodingNatBool
- finEncodingNatΓ'
- finEncodingPair
- inhabitedFinEncoding
- instance Γ.fintype {α : Type u} (e : FinEncoding α) : Fintype e.toEncoding.Γ
- unaryFinEncodingNat

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

AlexeyMilovanov and others added 3 commits April 12, 2026 00:00
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants