Skip to content

chore(SimpleGraph): move cycleGraph to its own file#37930

Open
vlad902 wants to merge 2 commits intoleanprover-community:masterfrom
vlad902:move-cycle-graph
Open

chore(SimpleGraph): move cycleGraph to its own file#37930
vlad902 wants to merge 2 commits intoleanprover-community:masterfrom
vlad902:move-cycle-graph

Conversation

@vlad902
Copy link
Copy Markdown
Collaborator

@vlad902 vlad902 commented Apr 11, 2026

PR #34797 re-defined cycleGraph independent of circulantGraph. Now move the definition of cycleGraph to its own file so that the definition can be used without importing the algebra hierarchy.

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2026 •
edited
Loading

PR summary 529f8af235

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.SimpleGraph.Circulant Mathlib.Combinatorics.SimpleGraph.Coloring.Constructions 1
Mathlib.Combinatorics.SimpleGraph.Cycle (new file) 808

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-combinatorics Combinatorics label Apr 11, 2026
@vlad902 vlad902 mentioned this pull request Apr 27, 2026
Open
3 tasks
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 30, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

mathlib-merge-conflicts Bot commented Apr 30, 2026

This pull request has conflicts, please merge master and resolve them.

vlad902 added 2 commits April 30, 2026 07:47
@vlad902
chore(SimpleGraph): move cycleGraph to its own file
5d21312 
PR leanprover-community#34797 re-defined `cycleGraph` independent of `circulantGraph`. Now
move the definition of `cycleGraph` to its own file so that the
definition can be used without importing the algebra hierarchy.
@vlad902
lake exe mk_all
574deae
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

t-combinatorics Combinatorics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vlad902