feat: custom simp sets for translating between Equiv and algebraic notation#38359
Open
mcdoll wants to merge 6 commits intoleanprover-community:masterfrom
Open
feat: custom simp sets for translating between Equiv and algebraic notation#38359mcdoll wants to merge 6 commits intoleanprover-community:masterfrom
simp sets for translating between Equiv and algebraic notation#38359mcdoll wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
PR summary 452dba9608Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.This script lives in the
|
mcdoll
added
t-meta
Vierkantor
reviewed
Apr 27, 2026
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
This approach makes sense to me, it seems a lot less messy than allowing a mix of definitions.
Agreed that the naming is not obvious. What do you think about calling them push_equiv and pull_equiv in analogy to the push_cast/push_neg/push tactics? Or push_end(omorphism)?
Member
Author
|
I like the idea, but which one would be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names for the simpsets are not great, I did ask on zulip, but no suggestions.
#mathlib4 > simpsets for moving between group and equiv