Skip to content

chore: kill some erws#38415

Open
yuanyi-350 wants to merge 15 commits intoleanprover-community:masterfrom
yuanyi-350:erw
Open

chore: kill some erws#38415
yuanyi-350 wants to merge 15 commits intoleanprover-community:masterfrom
yuanyi-350:erw

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

@yuanyi-350 yuanyi-350 commented Apr 23, 2026


Open in Gitpod

@yuanyi-350 yuanyi-350 requested a review from eric-wieser April 23, 2026 15:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

PR summary 977f84bd6e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (13.00, 0.02)
Current number Change Type
601 -13 erw

Current commit 6e91aae471
Reference commit 977f84bd6e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 23, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 23, 2026
- simplifies the proof passed to `Submodule.Quotient.equiv` in `tensorQuotientEquiv` to a single `simp [range_map_eq_span_tmul]`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 24, 2026
… an `erw` (#38418)

- rewrites `withDensityᵥ_rnDeriv_eq` to replace `erw [VectorMeasure.sub_apply]` with a plain `rw`
- adds `JordanDecomposition.toSignedMeasure` to the same rewrite chain so the proof closes without `erw`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 24, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

mathlib-dependent-issues Bot commented Apr 24, 2026

This PR/issue depends on:

mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
…rw (#38503)

- rewrites `exists_upperSemicontinuous_le_lintegral_le` to replace `erw [ENNReal.biSup_add]` with a plain `rw`
- uses `ENNReal.biSup_add'` so the rewrite closes without `erw`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
task_id: erw-elim-v3-0127
target_path: Mathlib/CategoryTheory/Localization/Construction.lean
artifact_path: /AI4M/users/lhchen/shouyi/results/candidates/erw-elim-v3-0127
task_id: erw-elim-v3-0117
target_path: Mathlib/CategoryTheory/Limits/Shapes/Images.lean
artifact_path: /AI4M/users/lhchen/shouyi/results/candidates/erw-elim-v3-0117
task_id: erw-elim-v3-0280
target_path: Mathlib/Topology/Sheaves/SheafCondition/PairwiseIntersections.lean
artifact_path: /AI4M/users/lhchen/shouyi/results/candidates/erw-elim-v3-0280
task_id: erw-elim-v3-0202
target_path: Mathlib/Geometry/RingedSpace/PresheafedSpace/HasColimits.lean
artifact_path: /AI4M/users/lhchen/shouyi/results/candidates/erw-elim-v3-0202
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- rewrites `BlockTriangular.det` to replace a `simp only` plus `erw` pair with a single `rw`
- uses `Matrix.det_reindex_self he.symm` directly in the rewrite chain

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- rewrites `lintegral_indicator_const_comp` to replace `erw [lintegral_comp ...]` with a plain `rw`
- uses `lintegral_map` at the start of the rewrite chain before `lintegral_indicator_const` and `Measure.map_apply`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 25, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- shortens the `uniq` proof in `unitIso` to `simp [functor, inverse, fac]`, removing the `dsimp` plus `erw [fac]` sequence

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
…38521)

- rewrites the sheafification whiskering lemmas with `simp only [sheafify, ...]`, removing the transparency workaround
- rewrites `whiskerRight_toSheafify_sheafifyCompIso_hom` with `simp only [toSheafify, sheafify, ...]` instead of `erw`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- adds `← comp_evaluation G k` to the simplification step, so `limitObjIsoLimitCompEvaluation_hom_π_assoc` no longer needs `erw`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
…38519)

- rewrites the sliced `dite` goals with `simp only`, replacing both `erw` steps in `isLimit`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- rewrites `Finset.sum_sigma` via `← Finset.univ_sigma_univ`, so the biproduct proof uses a plain `rw`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 26, 2026
#38506)

- rewrites the `TopCat.comp_app` step in `colimitPresheafObjIsoComponentwiseLimit` with `simp only [colimitCocone, colimit, ← TopCat.comp_app]`
- folds `colimitCocone_ι_app_c`, `limitObjIsoLimitCompEvaluation_inv_π_app_assoc`, and `limMap_π_assoc` into a single `rw` chain in `colimitPresheafObjIsoComponentwiseLimit_inv_ι_app`

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
mathlib-bors Bot pushed a commit that referenced this pull request Apr 26, 2026
- rewrites `kernelSubobject_arrow_comp_assoc` after inserting `← SimplicialObject.δ_def`, replacing the `erw` step

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants