Skip to content

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/SimpleFunc#38492

Open
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
yuanyi-350:M_5
Open

refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/SimpleFunc#38492
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
yuanyi-350:M_5

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

@yuanyi-350 yuanyi-350 commented Apr 25, 2026

  • rewrites Measurable.add_simpleFunc and Measurable.simpleFunc_add in MeasureTheory/Function/SimpleFunc to use SimpleFunc.measurable_bind instead of explicit inductions together with manual piecewise/support arguments

Extracted from #38104, migrate from #38107

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 25, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 25, 2026

Benchmark results for fbcd08b against 9268b22 are in. No significant results found. @yuanyi-350

  • 🟥 build//instructions: +6.3G (+0.00%)

Small changes (1🟥)

  • 🟥 build/module/Mathlib.MeasureTheory.MeasurableSpace.Card//instructions: +407.0M (+3.39%)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026

PR summary 9268b22206

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-measure-probability Measure theory / Probability theory label Apr 25, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declarations in this PR.

Results (seconds):

  • Measurable.add_simpleFunc: 0.140375 -> 0.019971 (-85.77%)
  • Measurable.simpleFunc_add: 0.136454 -> 0.018850 (-86.19%)

Overall:

  • both rewritten proofs are substantially faster than the previous induction-based versions.

@yuanyi-350 yuanyi-350 changed the title refactor(MeasureTheory): golf Function/SimpleFunc refactor(MeasureTheory): golf Mathlib/MeasureTheory/Function/SimpleFunc Apr 25, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me, thanks! Let's have another pair of eyes to double-check that we don't want to keep the old proofs for some reason:
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants