Skip to content

[Merged by Bors] - chore(LinearAlgebra/Matrix/Block): remove an erw#38501

Closed
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_1
Closed

[Merged by Bors] - chore(LinearAlgebra/Matrix/Block): remove an erw#38501
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_1

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • rewrites BlockTriangular.det to replace a simp only plus erw pair with a single rw
  • uses Matrix.det_reindex_self he.symm directly in the rewrite chain

Extracted from #38415

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 25, 2026
@yuanyi-350 yuanyi-350 mentioned this pull request Apr 25, 2026
18 tasks
@github-actions
Copy link
Copy Markdown

PR summary 9268b22206

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
628 -1 erw

Current commit 4e55520c24
Reference commit 9268b22206

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 25, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 25, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 25, 2026
- rewrites `BlockTriangular.det` to replace a `simp only` plus `erw` pair with a single `rw`
- uses `Matrix.det_reindex_self he.symm` directly in the rewrite chain

Extracted from #38415

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 25, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(LinearAlgebra/Matrix/Block): remove an erw [Merged by Bors] - chore(LinearAlgebra/Matrix/Block): remove an erw Apr 25, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 25, 2026
@yuanyi-350 yuanyi-350 deleted the E_1 branch April 27, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants