Skip to content

chore(Order/Hom/Basic): fix EquivLike OrderIso instance diamond#38559

Open
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:feature/order/delete-order-iso-equiv-like
Open

chore(Order/Hom/Basic): fix EquivLike OrderIso instance diamond#38559
SnirBroshi wants to merge 2 commits intoleanprover-community:masterfrom
SnirBroshi:feature/order/delete-order-iso-equiv-like

Conversation

@SnirBroshi
Copy link
Copy Markdown
Collaborator

@SnirBroshi SnirBroshi commented Apr 26, 2026

OrderIso is an abbrev for RelIso which already has an EquivLike instance.
Removing it creates issues with to_dual, so instead we make it defeq to the RelIso instance using inferInstance.

Zulip


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

PR summary 10a055a908

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Apr 26, 2026
@b-mehta b-mehta added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 26, 2026
@SnirBroshi
Copy link
Copy Markdown
Collaborator Author

Hmm, the errors are all due to to_dual having an issue translating a proof:

@[to_dual] failed to insert a cast to make `...` applied to `...` well typed

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 26, 2026
@JovanGerb
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by JovanGerb.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 26, 2026
@SnirBroshi SnirBroshi changed the title chore(Order/Hom/Basic): delete redundant EquivLike OrderIso instance chore(Order/Hom/Basic): fix EquivLike OrderIso instance Apr 26, 2026
@JovanGerb JovanGerb changed the title chore(Order/Hom/Basic): fix EquivLike OrderIso instance chore(Order/Hom/Basic): fix EquivLike OrderIso instance diamond Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants