Skip to content

feat(Geometry/Manifold): MfldCat is a CartesianMonoidalCategory#38560

Draft
Deicyde wants to merge 30 commits intoleanprover-community:masterfrom
Deicyde:mfldCat-CartesianMonoidal
Draft

feat(Geometry/Manifold): MfldCat is a CartesianMonoidalCategory#38560
Deicyde wants to merge 30 commits intoleanprover-community:masterfrom
Deicyde:mfldCat-CartesianMonoidal

Conversation

@Deicyde
Copy link
Copy Markdown
Contributor

@Deicyde Deicyde commented Apr 26, 2026

We prove that the category of a C^n manifolds is a Cartesian monoidal category. This PR introduces a new file Geometry/Manifold/Category/MfldCat/CartesianMonoidal closely mirroring the structure of Algebra/Category/Grp/CartesianMonoidal.lean


Open in Gitpod

Deicyde and others added 29 commits April 18, 2026 20:15
This reverts commit e1e7f6f.
This reverts commit 83e73fa.
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Added CatesianMonoidal structure analogous to GrpCat
@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 26, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

PR summary 9ee33d6428

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Geometry.Manifold.Category.MfldCat.Basic (new file) 2210
Mathlib.Geometry.Manifold.Category.MfldCat.CartesianMonoidal (new file) 2318

Declarations diff

+ Hom
+ Hom.Simps.hom
+ Hom.hom
+ MfldCat
+ binaryProductLimitCone
+ cartesianMonoidalCategory
+ coe_comp
+ coe_id
+ coe_of
+ const
+ const_apply
+ diffeomorphOfIso
+ hom_comp
+ hom_id
+ hom_ofHom
+ id_apply
+ inhabited
+ instance : BraidedCategory (MfldCat.{u} 𝕜 n) := .ofCartesianMonoidalCategory
+ instance : Category (MfldCat 𝕜 n)
+ instance : CoeSort (MfldCat 𝕜 n) (Type u) := ⟨MfldCat.carrier⟩
+ instance : ConcreteCategory (MfldCat 𝕜 n)
+ instance : HasForget₂ (MfldCat 𝕜 n) TopCat.{u}
+ isTerminalPoint
+ isoOfDiffeomorph
+ ofHom
+ ofHom_comp
+ ofHom_hom
+ ofHom_id
+ ofNormedSpace
+ of_carrier
+ of_diffeomorphOfIso
+ of_isoOfDiffeomorph
+ point
+ prodObj
+ tensorObj_eq

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (2.00, 0.01)
Current number Change Type
799 2 backward.privateInPublic
415 2 backward.privateInPublic.warn

Current commit 46643c4439
Reference commit 9ee33d6428

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-differential-geometry Manifolds etc label Apr 26, 2026
@Deicyde Deicyde force-pushed the mfldCat-CartesianMonoidal branch from 362846b to ccf72ba Compare April 26, 2026 22:40
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 26, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant